Fix and re-enable Linux TV commissioner-generated-passcode CI test #36291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
PR #36291: Size comparison from fef41bd to 2493621 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Oct 30, 2024
andy31415
reviewed
Oct 30, 2024
andy31415
reviewed
Oct 30, 2024
andy31415
reviewed
Oct 30, 2024
shaoltan-amazon
force-pushed
the
v13-branch
branch
from
2493621 to
6fff2eb
Compare
|
PR #36291: Size comparison from f985d72 to 6fff2eb Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Oct 30, 2024
shaoltan-amazon
force-pushed
the
v13-branch
branch
2 times, most recently
from
f6887b1 to
51a0941
Compare
|
PR #36291: Size comparison from a6f0168 to 51a0941 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
sharadb-amazon
approved these changes
Oct 31, 2024
andy31415
reviewed
Oct 31, 2024
andy31415
approved these changes
Oct 31, 2024
…logic per @andy31415 suggestion
auto-merge was automatically disabled
October 31, 2024 18:38
Head branch was pushed to by a user without write access
shaoltan-amazon
force-pushed
the
v13-branch
branch
from
51a0941 to
a5d86a2
Compare
andy31415
reviewed
Oct 31, 2024
|
PR #36291: Size comparison from f0e3672 to dabce3e Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34598The Linux TV commissioner-generated-passcode test flow was flaky due to buffering issues when attempting to read from the output (and error) stream(s).
Changes made:
_io_threadto read all the output available in the output stream and store them directly to the output queue.Note:
Commented out the last few steps in the commissioner-generated-passcode test flow as there seems to be a new issue that came up recently where we are subscribing to an endpoint with 0 clusters (which should not be the case). See #36289 for more details. These test sequence steps should be enabled once #36289 is fixed.
Testing