[nRF Connect] Update README - Building with Docker #3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instruction for building nRF Connect examples using a Docker container was changed recently to use a non-root user for security and usability reasons. The Docker image, however, used a fixed user ID, 1000, which doesn't necessarily match the current user ID. As a result a user outside the container might still not be able to remove files created in the container. Pass the current user ID to the Docker container by an environmental variable handled in the container so that the container session is run as the current user.
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
andy31415
approved these changes
Nov 3, 2020
mspang
approved these changes
Nov 3, 2020
rwalker-apple
approved these changes
Nov 4, 2020
jelderton
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The instruction for building nRF Connect examples using a Docker container was changed recently to use a non-root user for security and usability reasons. The Docker image, however, used a fixed user ID, 1000, which doesn't necessarily match the current user ID. As a result a user outside the container might still not be able to remove files created in the container.
Summary of Changes
Pass the current user ID to the Docker container by an environmental variable handled in the container so that the container session is run as the current user.