Post merge cleanup 36229 ember buffer encode #36266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #36266: Size comparison from 2142870 to 469c65a Full report (7 builds for cc13x4_26x4, cc32xx, stm32)
|
|
PR #36266: Size comparison from 2142870 to ed35ddd Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #36266: Size comparison from 2142870 to 7ac4e4f Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
src/app/codegen-data-model-provider/EmberAttributeDataBuffer.cpp
Outdated
Show resolved
Hide resolved
src/app/codegen-data-model-provider/EmberAttributeDataBuffer.cpp
Outdated
Show resolved
Hide resolved
src/app/codegen-data-model-provider/EmberAttributeDataBuffer.cpp
Outdated
Show resolved
Hide resolved
src/app/codegen-data-model-provider/EmberAttributeDataBuffer.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Done. Did not see header comments. The comment was a copy and paste and it turned out handling both signed and unsigned into a single method was smaller code. |
bzbarsky-apple
approved these changes
Oct 28, 2024
cecille
approved these changes
Oct 28, 2024
jmartinez-silabs
approved these changes
Oct 28, 2024
|
PR #36266: Size comparison from 928efd7 to 3d364fa Full report (10 builds for cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #36266: Size comparison from 928efd7 to 5a2681f Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #36266: Size comparison from 928efd7 to 8276b4d Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
Oct 28, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Use chip::app::IsSignedAttributeType * Fix up put as well as naming for null value and comment * Fix up nullable tests * Test that you cannot decode a null value for non-nullable double and single * Allow NAN for non-nullable floating points * Add test case for non nullable bool * Restyle * Add a header for efr32 * Update src/app/codegen-data-model-provider/EmberAttributeDataBuffer.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/codegen-data-model-provider/EmberAttributeDataBuffer.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Remove extra comment * Replace switch with if * Comment fix * Another try to make efr32 build of tests happy * Move includes around, to try to work around issues within efr32 compiles... * more updates, this time local efr32 compiles --------- Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes post review comments from @bzbarsky-apple on #36229