Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to use the lwip library on Darwin. #36258

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Don't try to use the lwip library on Darwin. #36258

merged 1 commit into from
Oct 28, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Oct 27, 2024 •
edited
Loading

Don't try to build against the library, and don't check out the submodule for the darwin platform.

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 27, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 1 of 3 files.

Filename Status
❔ .gitmodules Unsupported file format
❔ src/lwip/lwip.gni Unsupported file format
✔️ scripts/checkout_submodules.py Analyzed

@bzbarsky-apple bzbarsky-apple force-pushed the try-excluding-lwip-darwin branch from 63cdeba to d2b8fd1 Compare October 27, 2024 06:25
@github-actions GitHub Actions
Copy link

PR #36258: Size comparison from ac43b68 to d2b8fd1

Full report (1 build for stm32)
platform target config section ac43b68 d2b8fd1 change % change
stm32 light STM32WB5MM-DK FLASH 481920 481920 0 0.0
RAM 144844 144844 0 0.0

@bzbarsky-apple bzbarsky-apple added the changing-submodules-on-purpose Marker that this PR is changing submodules (and it is not a "commit all" typo/mistake) label Oct 27, 2024
@bzbarsky-apple bzbarsky-apple force-pushed the try-excluding-lwip-darwin branch from d2b8fd1 to 4bcb0c1 Compare October 27, 2024 06:43
@bzbarsky-apple bzbarsky-apple changed the title Testing not having lwip submodule on darwin Don't try to use the lwip library on Darwin. Oct 27, 2024
@bzbarsky-apple
Don't try to use the lwip library on Darwin.
6064f4c 
Don't try to build against the library, and don't check out the submodule for
the darwin platform.
@bzbarsky-apple bzbarsky-apple force-pushed the try-excluding-lwip-darwin branch from 4bcb0c1 to 6064f4c Compare October 27, 2024 06:46
@bzbarsky-apple bzbarsky-apple marked this pull request as ready for review October 27, 2024 06:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 27, 2024 •
edited
Loading

PR #36258: Size comparison from ac43b68 to 6064f4c

Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section ac43b68 6064f4c change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1350120 1350120 0 0.0
RAM 104120 104120 0 0.0
bl702 lighting-app bl702+eth FLASH 647856 647856 0 0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 825164 825164 0 0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1054154 1054154 0 0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 974938 974938 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 836660 836660 0 0.0
RAM 123676 123676 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 821960 821960 0 0.0
RAM 125556 125556 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 768532 768532 0 0.0
RAM 114048 114048 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 752792 752792 0 0.0
RAM 114240 114240 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 627466 627466 0 0.0
RAM 206132 206132 0 0.0
lock CC3235SF_LAUNCHXL FLASH 667458 667458 0 0.0
RAM 206284 206284 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678621 678621 0 0.0
RAM 78692 78692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698465 698465 0 0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698465 698465 0 0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655401 655401 0 0.0
RAM 73760 73760 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615037 615037 0 0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634665 634665 0 0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634665 634665 0 0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634309 634309 0 0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 654017 654017 0 0.0
RAM 77244 77244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 654017 654017 0 0.0
RAM 77244 77244 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609669 609669 0 0.0
RAM 68780 68780 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629521 629521 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629521 629521 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 925644 925644 0 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 742216 742216 0 0.0
RAM 232580 232580 0 0.0
window-app BRD4187C FLASH 1018568 1018568 0 0.0
RAM 128264 128264 0 0.0
esp32 all-clusters-app c3devkit DRAM 95256 95256 0 0.0
FLASH 1540020 1540020 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 116192 116192 0 0.0
FLASH 1550194 1550194 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2743551 2743551 0 0.0
RAM 129520 129520 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6058996 6058996 0 0.0
RAM 523840 523840 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5387580 5387580 0 0.0
RAM 242416 242416 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4711492 4711492 0 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 13067000 13067000 0 0.0
RAM 584466 584466 0 0.0
chip-tool-ipv6only arm64 unknown 21408 21408 0 0.0
FLASH 11176872 11176872 0 0.0
RAM 635408 635408 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11315089 11315089 0 0.0
RAM 584954 584954 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4537340 4537340 0 0.0
RAM 205336 205336 0 0.0
fabric-sync debug unknown 4816 4816 0 0.0
FLASH 5250741 5250741 0 0.0
RAM 465416 465416 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5655537 5655537 0 0.0
RAM 228488 228488 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4760920 4760920 0 0.0
RAM 204472 204472 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4387630 4387630 0 0.0
RAM 198192 198192 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4527438 4527438 0 0.0
RAM 202760 202760 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3082493 3082493 0 0.0
RAM 160368 160368 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4130768 4130768 0 0.0
RAM 242896 242896 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 5994373 5994373 0 0.0
RAM 596256 596256 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11274733 11274733 0 0.0
RAM 694536 694536 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915564 915564 0 0.0
RAM 143357 143357 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 886032 886032 0 0.0
RAM 141496 141496 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848972 848972 0 0.0
RAM 142265 142265 0 0.0
nxp contact k32w0+release FLASH 582424 582424 0 0.0
RAM 71092 71092 0 0.0
mcxw71+release FLASH 596896 596896 0 0.0
RAM 63184 63184 0 0.0
light k32w0+release FLASH 619044 619044 0 0.0
RAM 70556 70556 0 0.0
k32w1+release FLASH 683144 683144 0 0.0
RAM 48816 48816 0 0.0
lock mcxw71+release FLASH 746704 746704 0 0.0
RAM 67340 67340 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1647668 1647668 0 0.0
RAM 212408 212408 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553740 1553740 0 0.0
RAM 209208 209208 0 0.0
light cy8ckit_062s2_43012 FLASH 1468004 1468004 0 0.0
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464964 1464964 0 0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660536 660536 0 0.0
RAM 105420 105420 0 0.0
lock-app qpg6105+debug FLASH 618628 618628 0 0.0
RAM 99880 99880 0 0.0
stm32 light STM32WB5MM-DK FLASH 481920 481920 0 0.0
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 681136 681136 0 0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620782 620782 0 0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708762 708762 0 0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625736 625736 0 0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811746 811746 0 0.0
RAM 99100 99100 0 0.0
tizen all-clusters-app arm unknown 4912 4912 0 0.0
FLASH 1729952 1729952 0 0.0
RAM 90108 90108 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 18268902 18268902 0 0.0
RAM 7960480 7960480 0 0.0

@mergify mergify bot merged commit 215cb5c into project-chip:master Oct 28, 2024
68 checks passed
@bzbarsky-apple bzbarsky-apple deleted the try-excluding-lwip-darwin branch October 28, 2024 17:09
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@bzbarsky-apple @yyzhong-g
Don't try to use the lwip library on Darwin. (project-chip#36258)
4970898 
Don't try to build against the library, and don't check out the submodule for
the darwin platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@mkardous-silabs mkardous-silabs mkardous-silabs approved these changes

Assignees
No one assigned
Labels
changing-submodules-on-purpose Marker that this PR is changing submodules (and it is not a "commit all" typo/mistake) lwip review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @mkardous-silabs