[Silabs] Dishwasher Comparison Always false fix #36234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
andy31415
approved these changes
Oct 24, 2024
|
PR #36234: Size comparison from 1febc9b to f94e409 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Oct 24, 2024
| @@ -196,12 +196,12 @@ void ElectricalSensorManager::UpdateEPMAttributes(OperationalStateEnum state) | |||
| { | |||
| if (gEPMDelegate) | |||
| { | |||
| uint16_t updateState = to_underlying(state); | |||
| uint16_t ERROR_STATE_INDEX = ArraySize(kAttributes) - 1; | |||
| uint8_t updateState = to_underlying(state); | |||
There was a problem hiding this comment.
In the future, I would recommend auto in this situation. That prevents accidental narrowing (which would also be prevented if this code were built with -Wconversion, but I bet it's not).
lpbeliveau-silabs
deleted the
bugfix/remove_useless_check_electrical_sensor
branch
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed un-necessary check in Electrical Sensor Manager
Fixes : #36050