TC-ALOGIN-12.2 - updates step 2 as per verification steps #36206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
github-actions
bot
added
app
tests
matter-1.4-te2-script-change
|
PR #36206: Size comparison from e36bde7 to 5d22c7c Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Rajashreekalmane
approved these changes
Oct 23, 2024
|
PR #36206: Size comparison from a0d7b14 to de18434 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36206: Size comparison from 00890a6 to 4262f40 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
approved these changes
Oct 25, 2024
Comment on lines
+111
to
+112
| ./chip-tool accountlogin login 11111 20202021 1 4 --timedInteractionTimeoutMs 1000 | ||
| ./chip-tv-casting-app accountlogin login 11111 20202021 1 4 --timedInteractionTimeoutMs 1000 |
There was a problem hiding this comment.
The correct value here would depend on the relevant DUT, no? Why are we changin this to "20202021" specifically? It would be better to make it clear that the value here is a placeholder that would need to get replaced with the right value at test time.
There was a problem hiding this comment.
@Rajashreekalmane, can you address this comment?
There was a problem hiding this comment.
I’ve updated the Verification Sheet to address your comment regarding the placeholder value "20202021." The value is now explicitly marked as a placeholder, with a note indicating that it should be replaced with the appropriate value based on the relevant DUT at test time.
Here are the clarified instructions:
./chip-tool accountlogin login <TempAccountIdentifier> <SetupPIN> <destination-id> <endpoint-id-ignored-for-group-commands> [optional flags]
Argument Descriptions
TempAccountIdentifier: Replace it with the appropriate identifier for your DUT.
SetupPIN: Replace it with the PIN specific to your DUT.
destination-id: Replace it with the actual node ID of the DUT.
Example Command:
./chip-tool accountlogin login 11111 20202021 1 4 --timedInteractionTimeoutMs 1000
Updated Verification document for your reference : https://docs.google.com/spreadsheets/d/13zltSz50GRs_kidvobceEuIT8kAAHSK64ANyWcc3xQI/edit?usp=sharing
There was a problem hiding this comment.
OK, so the PR should be updated accordingly, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
[TC-ALOGIN-12.2]UI Manual - In Test step 2 command has to be updated as per Verification step document #366