Improve Exit Error Handling for failures in PASE pairing requests #36160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #36160: Size comparison from 79c1cf5 to 4ca3af6 Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/PASEErrorHandling
branch
from
4ca3af6 to
7cb692f
Compare
Alami-Amine
changed the title
Alami-Amine
changed the title
|
PR #36160: Size comparison from 79c1cf5 to 7cb692f Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
requested changes
Oct 21, 2024
Alami-Amine
force-pushed
the
AA/PASEErrorHandling
branch
from
c5482f4 to
dd11eaf
Compare
|
PR #36160: Size comparison from 6f0a70c to dd11eaf Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36160: Size comparison from 6f0a70c to 283039c Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Oct 22, 2024
andy31415
approved these changes
Oct 22, 2024
|
PR #36160: Size comparison from 6f0a70c to 25ad622 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
Alami-Amine
force-pushed
the
AA/PASEErrorHandling
branch
from
25ad622 to
55e346b
Compare
|
PR #36160: Size comparison from 5c0c92e to 55e346b Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…oject-chip#36160) * Improve Error Handling for failures in PASE pairing requests * Integrating comments * clarifying Pair API contract regarding the delegate * integrating comment on API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PASESession::Pair, the exit is not as clean as it should be.If a failure happens in the call to
PASESession::Init, (triggered by passing a bigger setup passcode when fuzzing), the Exchange Context is not properly destructed becuase theReferenceCountis not equal to 0.exchangeCtxt->Close();Error Log before Fix: