-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing device types solar pv, battery storage, heat pump #36147
Merged
mergify
merged 3 commits into
project-chip:master
from
jamesharrow:Add-Missing-device-types-SolarPV,-BatteryStorage,-HeatPump
Oct 24, 2024
Merged
Add missing device types solar pv, battery storage, heat pump #36147
mergify
merged 3 commits into
project-chip:master
from
jamesharrow:Add-Missing-device-types-SolarPV,-BatteryStorage,-HeatPump
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. |
PR #36147: Size comparison from 728d138 to 8a0276a Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
soares-sergio
approved these changes
Oct 21, 2024
…-BatteryStorage,-HeatPump
PR #36147: Size comparison from b99a978 to 52c755e Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Oct 24, 2024
bzbarsky-apple
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, I guess, but I am not a fan of making XML updates harder to review.
jamesharrow
deleted the
Add-Missing-device-types-SolarPV,-BatteryStorage,-HeatPump
branch
October 24, 2024 17:24
TE-N-ElvenWang
pushed a commit
to NXP/matter
that referenced
this pull request
Dec 6, 2024
…ect-chip#36147) * Added Heat Pump, Solar Power, Battery Storage to matter-devices.xml * Update after regen_all Change-Id: Iae699d22cf5732bb916c49b70251701f8324a002 Reviewed-on: http://androidsource.nxp.com/project/26509 Reviewed-by: Elven Wang <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…t-chip#36147) * Added Heat Pump, Solar Power, Battery Storage to matter-devices.xml * Update after regen_all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autogenerated from Alchemy, rename the clusters to remove 'Matter' which is consistent with #36125
Used: https://github.com/project-chip/alchemy/releases/download/v0.8.3/alchemy-0.8.3-linux-amd64.tar.gz
./alchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/ --specRoot=./connectedhomeip_spec ./connectedhomeip_spec/src/device_types/HeatPump.adoc
./alchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/ --specRoot=./connectedhomeip_spec ./connectedhomeip_spec/src/device_types/SolarPower.adoc
./alchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/ --specRoot=./connectedhomeip_spec ./connectedhomeip_spec/src/device_types/BatteryStorage.adoc
Then
./scripts/tools/zap_regen_all.py