Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Silabs] Reduce the amount of target built by the ci while keeping almost the sa… #36043

Merged
merged 2 commits into from
Oct 11, 2024
Merged

[Silabs] Reduce the amount of target built by the ci while keeping almost the sa… #36043

merged 2 commits into from
Oct 11, 2024

Conversation

jmartinez-silabs
Copy link
Member

@jmartinez-silabs jmartinez-silabs commented Oct 11, 2024 •
edited
Loading

…me code coverage in order to reduce ci runtime

  • Dropping a few variants of the lighting app build. They are covered in other targets now.
  • Dropping pump-app build (there could be a gap now but it has been a pretty stable/untouched app)
  • Each wifi SOC each have 1 target rather than both building the same 2 targets.
  • drop the bloat report for the second wifi soc. The results would be the same.

a run Before this PR:
EFR32 CI ran in 1h 24m 27s

run from this pr
EFR32 CI ran in 57m 0s

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@jmartinez-silabs jmartinez-silabs changed the title [Silabs] Reduce the amount of target build by the ci why keeping almost the sa… [Silabs] Reduce the amount of target built by the ci while keeping almost the sa… Oct 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

PR #36043: Size comparison from 3732a89 to 46f23d5

Full report (48 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
platform target config section 3732a89 46f23d5 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1349642 1349642 0 0.0
RAM 103928 103928 0 0.0
bl702 lighting-app bl702+eth FLASH 647678 647678 0 0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 825164 825164 0 0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1053794 1053794 0 0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 974934 974934 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829460 829460 0 0.0
RAM 123292 123292 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814792 814792 0 0.0
RAM 125172 125172 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761356 761356 0 0.0
RAM 113664 113664 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745584 745584 0 0.0
RAM 113856 113856 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 617114 617114 0 0.0
RAM 205396 205396 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657218 657218 0 0.0
RAM 205548 205548 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678437 678437 0 0.0
RAM 78508 78508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698281 698281 0 0.0
RAM 81140 81140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698281 698281 0 0.0
RAM 81140 81140 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655217 655217 0 0.0
RAM 73576 73576 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614765 614765 0 0.0
RAM 71468 71468 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634393 634393 0 0.0
RAM 74020 74020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634393 634393 0 0.0
RAM 74020 74020 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634085 634085 0 0.0
RAM 74516 74516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653793 653793 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653793 653793 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609389 609389 0 0.0
RAM 68604 68604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629249 629249 0 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629249 629249 0 0.0
RAM 71236 71236 0 0.0
esp32 all-clusters-app c3devkit DRAM 94088 94088 0 0.0
FLASH 1538650 1538650 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115032 115032 0 0.0
FLASH 1548994 1548994 0 0.0
IRAM 117039 117039 0 0.0
linux chip-tool-ipv6only arm64 unknown 20880 20880 0 0.0
FLASH 11396560 11396560 0 0.0
RAM 618432 618432 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4319472 4319472 0 0.0
RAM 242888 242888 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914420 914420 0 0.0
RAM 142199 142199 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885228 885228 0 0.0
RAM 140338 140338 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847836 847836 0 0.0
RAM 141101 141101 0 0.0
nxp contact k32w0+release FLASH 582168 582168 0 0.0
RAM 70792 70792 0 0.0
k32w1+release FLASH 597000 597000 0 0.0
RAM 63016 63016 0 0.0
mcxw71+release FLASH 596760 596760 0 0.0
RAM 63016 63016 0 0.0
light k32w0+release FLASH 618700 618700 0 0.0
RAM 70256 70256 0 0.0
k32w1+release FLASH 683008 683008 0 0.0
RAM 48648 48648 0 0.0
mcxw71+release FLASH 683008 683008 0 0.0
RAM 48648 48648 0 0.0
lock k32w1+release FLASH 705360 705360 0 0.0
RAM 67156 67156 0 0.0
mcxw71+release FLASH 705368 705368 0 0.0
RAM 67156 67156 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646292 1646292 0 0.0
RAM 210888 210888 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552356 1552356 0 0.0
RAM 207688 207688 0 0.0
light cy8ckit_062s2_43012 FLASH 1467828 1467828 0 0.0
RAM 200688 200688 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464900 1464900 0 0.0
RAM 225048 225048 0 0.0
qpg lighting-app qpg6105+debug FLASH 660488 660488 0 0.0
RAM 105236 105236 0 0.0
lock-app qpg6105+debug FLASH 618508 618508 0 0.0
RAM 99704 99704 0 0.0
stm32 light STM32WB5MM-DK FLASH 481784 481784 0 0.0
RAM 144684 144684 0 0.0
tizen all-clusters-app arm unknown 4904 4904 0 0.0
FLASH 1726732 1726732 0 0.0
RAM 89084 89084 0 0.0
chip-tool-ubsan arm unknown 10528 10528 0 0.0
FLASH 17718354 17718354 0 0.0
RAM 7714704 7714704 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

PR #36043: Size comparison from 3732a89 to 9461f6e

Increases above 0.2%:

platform target config section 3732a89 9461f6e change % change
nxp contact k32w1+release RAM 63016 63176 160 0.3
mcxw71+release RAM 63016 63176 160 0.3
light k32w1+release RAM 48648 48808 160 0.3
mcxw71+release RAM 48648 48808 160 0.3
psoc6 light cy8ckit_062s2_43012 RAM 200688 201200 512 0.3
telink air-quality-sensor-app tlsr9528a_retention RAM 50488 50648 160 0.3
contact-sensor-app tlsr9528a_retention RAM 50440 50600 160 0.3
light-switch-app-ota-shell-factory-data tlsr9528a RAM 73780 73940 160 0.2
lock-app-dfu tlsr9528a RAM 66500 66660 160 0.2
pump-app-usb tlsr9518adk80d RAM 55316 55476 160 0.3
pump-controller-app tlsr9518adk80d RAM 52560 52720 160 0.3
smoke_co_alarm-app tlsr9528a_retention RAM 52160 52320 160 0.3
temperature-measurement-app-mars-ota tlsr9518adk80d RAM 56108 56268 160 0.3
thermostat tlsr9518adk80d RAM 52952 53112 160 0.3
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 3732a89 9461f6e change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1349642 1349682 40 0.0
RAM 103928 104120 192 0.2
bl702 lighting-app bl702+eth FLASH 647678 647718 40 0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 825164 825204 40 0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1053794 1053834 40 0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 974934 974974 40 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829460 829492 32 0.0
RAM 123292 123452 160 0.1
lock-ftd LP_EM_CC1354P10_6 FLASH 814792 814832 40 0.0
RAM 125172 125332 160 0.1
pump-app LP_EM_CC1354P10_6 FLASH 761356 761396 40 0.0
RAM 113664 113824 160 0.1
pump-controller-app LP_EM_CC1354P10_6 FLASH 745584 745624 40 0.0
RAM 113856 114016 160 0.1
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 617114 617154 40 0.0
RAM 205396 205908 512 0.2
lock CC3235SF_LAUNCHXL FLASH 657218 657258 40 0.0
RAM 205548 206060 512 0.2
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678437 678477 40 0.0
RAM 78508 78668 160 0.2
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698281 698321 40 0.0
RAM 81140 81300 160 0.2
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698281 698321 40 0.0
RAM 81140 81300 160 0.2
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655217 655257 40 0.0
RAM 73576 73736 160 0.2
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614765 614805 40 0.0
RAM 71468 71628 160 0.2
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634393 634433 40 0.0
RAM 74020 74180 160 0.2
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634393 634433 40 0.0
RAM 74020 74180 160 0.2
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634085 634125 40 0.0
RAM 74516 74676 160 0.2
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653793 653833 40 0.0
RAM 77068 77228 160 0.2
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653793 653833 40 0.0
RAM 77068 77228 160 0.2
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609389 609429 40 0.0
RAM 68604 68764 160 0.2
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629249 629289 40 0.0
RAM 71236 71396 160 0.2
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629249 629289 40 0.0
RAM 71236 71396 160 0.2
efr32 lock-app BRD4338a FLASH 741288 741344 56 0.0
RAM 230848 231008 160 0.1
window-app BRD4187C FLASH 1018108 1018140 32 0.0
RAM 127892 128052 160 0.1
esp32 all-clusters-app c3devkit DRAM 94088 94248 160 0.2
FLASH 1538650 1538700 50 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115032 115192 160 0.1
FLASH 1548994 1549010 16 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2780949 2781021 72 0.0
RAM 129520 129520 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6085554 6085626 72 0.0
RAM 514752 514752 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5418228 5418300 72 0.0
RAM 241200 241200 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4751700 4751772 72 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12780226 12780298 72 0.0
RAM 567890 567890 0 0.0
chip-tool-ipv6only arm64 unknown 20880 20880 0 0.0
FLASH 11396560 11396576 16 0.0
RAM 618432 618432 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11091097 11091169 72 0.0
RAM 567578 567578 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4575330 4575402 72 0.0
RAM 205048 205048 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5692289 5692353 64 0.0
RAM 228488 228488 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4801264 4801336 72 0.0
RAM 204472 204472 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4430688 4430760 72 0.0
RAM 198192 198192 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4569502 4569574 72 0.0
RAM 202760 202760 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3111005 3111085 80 0.0
RAM 159280 159280 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4319472 4319488 16 0.0
RAM 242888 242888 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6029621 6029685 64 0.0
RAM 588256 588256 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10979293 10979373 80 0.0
RAM 656960 656960 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914420 914460 40 0.0
RAM 142199 142359 160 0.1
nrf7002dk_nrf5340_cpuapp FLASH 885228 885276 48 0.0
RAM 140338 140498 160 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847836 847880 44 0.0
RAM 141101 141261 160 0.1
nxp contact k32w0+release FLASH 582168 582216 48 0.0
RAM 70792 70952 160 0.2
k32w1+release FLASH 597000 597048 48 0.0
RAM 63016 63176 160 0.3
mcxw71+release FLASH 596760 596808 48 0.0
RAM 63016 63176 160 0.3
light k32w0+release FLASH 618700 618732 32 0.0
RAM 70256 70416 160 0.2
k32w1+release FLASH 683008 683040 32 0.0
RAM 48648 48808 160 0.3
mcxw71+release FLASH 683008 683040 32 0.0
RAM 48648 48808 160 0.3
lock k32w1+release FLASH 705360 705408 48 0.0
RAM 67156 67316 160 0.2
mcxw71+release FLASH 705368 705416 48 0.0
RAM 67156 67316 160 0.2
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646292 1646340 48 0.0
RAM 210888 211400 512 0.2
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552356 1552388 32 0.0
RAM 207688 208200 512 0.2
light cy8ckit_062s2_43012 FLASH 1467828 1467860 32 0.0
RAM 200688 201200 512 0.3
lock cy8ckit_062s2_43012 FLASH 1464900 1464932 32 0.0
RAM 225048 225560 512 0.2
qpg lighting-app qpg6105+debug FLASH 660488 660528 40 0.0
RAM 105236 105396 160 0.2
lock-app qpg6105+debug FLASH 618508 618548 40 0.0
RAM 99704 99864 160 0.2
stm32 light STM32WB5MM-DK FLASH 481784 481824 40 0.0
RAM 144684 144844 160 0.1
telink air-quality-sensor-app tlsr9528a_retention FLASH 620946 620986 40 0.0
RAM 50488 50648 160 0.3
all-clusters-app tlsr9118bdk40d FLASH 688144 688188 44 0.0
RAM 148328 148488 160 0.1
all-clusters-minimal-app tlsr9528a FLASH 781136 781180 44 0.0
RAM 110280 110440 160 0.1
bridge-app tlsr9258a FLASH 681042 681086 44 0.0
RAM 91144 91304 160 0.2
contact-sensor-app tlsr9528a_retention FLASH 620710 620750 40 0.0
RAM 50440 50600 160 0.3
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708652 708692 40 0.0
RAM 73780 73940 160 0.2
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625648 625692 44 0.0
RAM 144308 144468 160 0.1
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811408 811452 44 0.0
RAM 98940 99100 160 0.2
lock-app-dfu tlsr9528a FLASH 656616 656656 40 0.0
RAM 66500 66660 160 0.2
ota-requestor-app tlsr9258a FLASH 697020 697064 44 0.0
RAM 90736 90896 160 0.2
pump-app-usb tlsr9518adk80d FLASH 634344 634384 40 0.0
RAM 55316 55476 160 0.3
pump-controller-app tlsr9518adk80d FLASH 611534 611574 40 0.0
RAM 52560 52720 160 0.3
shell tlsr9518adk80d FLASH 467872 467872 0 0.0
RAM 68168 68168 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627860 627900 40 0.0
RAM 52160 52320 160 0.3
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653666 653706 40 0.0
RAM 56108 56268 160 0.3
thermostat tlsr9518adk80d FLASH 638266 638306 40 0.0
RAM 52952 53112 160 0.3
window-covering tlsr9118bdk40d FLASH 524404 524444 40 0.0
RAM 97284 97444 160 0.2
tizen all-clusters-app arm unknown 4904 4904 0 0.0
FLASH 1726732 1726772 40 0.0
RAM 89084 89084 0 0.0
chip-tool-ubsan arm unknown 10528 10528 0 0.0
FLASH 17718354 17718602 248 0.0
RAM 7714704 7714800 96 0.0

@lpbeliveau-silabs
Copy link
Contributor

lpbeliveau-silabs commented Oct 11, 2024 •
edited
Loading

Maybe add in the PR / Commit comment what coverage has changed from this PR. Just so we keep track.

From what I see main difference is we do not build the pump app but there probably is more to it.

@andy31415 andy31415 merged commit d2d06b3 into project-chip:master Oct 11, 2024
68 of 69 checks passed
@jmartinez-silabs jmartinez-silabs deleted the ci/reduce_silabs_targets_to_build branch October 11, 2024 18:47
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@jmartinez-silabs @yyzhong-g
[Silabs] Reduce the amount of target built by the ci while keeping al…
4689a2d 
…most the sa… (project-chip#36043)

* Reduce the amount of target build by the ci why keeping almost the same code coverage

* Fix missing target change in bloat report
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpbeliveau-silabs lpbeliveau-silabs lpbeliveau-silabs approved these changes

@andy31415 andy31415 andy31415 approved these changes

Assignees
No one assigned
Labels
github review - pending workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmartinez-silabs @lpbeliveau-silabs @andy31415