Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICD] Store icdClientInfo after completing check-in message validation #36026

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[ICD] Store icdClientInfo after completing check-in message validation #36026

merged 1 commit into from
Oct 10, 2024

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Oct 10, 2024 •
edited
Loading

Issue: Currently offset in icdClientInfo has not yet updated after completing check-in message validation so that duplicate icd check-in message cannot be detected.
Fix: Store IcdClientInfo when completing check-in message validation.
locally validated using chip-tool

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@github-actions github-actions bot added app icd Intermittently Connected Devices labels Oct 10, 2024
@yunhanw-google yunhanw-google enabled auto-merge (squash) October 10, 2024 21:02
@yunhanw-google yunhanw-google mentioned this pull request Oct 10, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

PR #36026: Size comparison from 6880437 to bf7585b

Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 6880437 bf7585b change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1349640 1349640 0 0.0
RAM 103928 103928 0 0.0
bl702 lighting-app bl702+eth FLASH 647678 647678 0 0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 825164 825164 0 0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1053792 1053792 0 0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 974932 974932 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829460 829460 0 0.0
RAM 123292 123292 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814792 814792 0 0.0
RAM 125172 125172 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761356 761356 0 0.0
RAM 113664 113664 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745584 745584 0 0.0
RAM 113856 113856 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 617114 617114 0 0.0
RAM 205396 205396 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657218 657218 0 0.0
RAM 205548 205548 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678437 678437 0 0.0
RAM 78508 78508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698281 698281 0 0.0
RAM 81140 81140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698281 698281 0 0.0
RAM 81140 81140 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655217 655217 0 0.0
RAM 73576 73576 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614765 614765 0 0.0
RAM 71468 71468 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634393 634393 0 0.0
RAM 74020 74020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634393 634393 0 0.0
RAM 74020 74020 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634085 634085 0 0.0
RAM 74516 74516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653793 653793 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653793 653793 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609389 609389 0 0.0
RAM 68604 68604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629249 629249 0 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629249 629249 0 0.0
RAM 71236 71236 0 0.0
efr32 lighting-app BRD4187C FLASH 934544 934544 0 0.0
RAM 135956 135956 0 0.0
lock-app BRD2605a FLASH 740640 740632 -8 -0.0
RAM 230816 230816 0 0.0
BRD4338a FLASH 741288 741280 -8 -0.0
RAM 230848 230848 0 0.0
window-app BRD4187C FLASH 1018108 1018108 0 0.0
RAM 127892 127892 0 0.0
esp32 all-clusters-app c3devkit DRAM 94088 94088 0 0.0
FLASH 1538682 1538682 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115032 115032 0 0.0
FLASH 1549018 1549018 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2780949 2780949 0 0.0
RAM 129520 129520 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6085554 6085554 0 0.0
RAM 514752 514752 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5418228 5418228 0 0.0
RAM 241200 241200 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4751700 4751700 0 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12780170 12780226 56 0.0
RAM 567890 567890 0 0.0
chip-tool-ipv6only arm64 unknown 20880 20880 0 0.0
FLASH 11396544 11396576 32 0.0
RAM 618432 618432 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11091073 11091129 56 0.0
RAM 567578 567578 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4575330 4575330 0 0.0
RAM 205048 205048 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5692289 5692289 0 0.0
RAM 228488 228488 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4801264 4801264 0 0.0
RAM 204472 204472 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4430688 4430688 0 0.0
RAM 198192 198192 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4569502 4569502 0 0.0
RAM 202760 202760 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3111005 3111005 0 0.0
RAM 159280 159280 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4319472 4319472 0 0.0
RAM 242888 242888 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6029621 6029621 0 0.0
RAM 588256 588256 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 1097932 1097932 0 0.0
RAM 656960 656960 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914420 914420 0 0.0
RAM 142199 142199 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885228 885228 0 0.0
RAM 140338 140338 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847836 847836 0 0.0
RAM 141101 141101 0 0.0
nxp contact k32w0+release FLASH 582168 582168 0 0.0
RAM 70792 70792 0 0.0
k32w1+release FLASH 597000 597000 0 0.0
RAM 63016 63016 0 0.0
mcxw71+release FLASH 596760 596760 0 0.0
RAM 63016 63016 0 0.0
light k32w0+release FLASH 618700 618700 0 0.0
RAM 70256 70256 0 0.0
k32w1+release FLASH 683008 683008 0 0.0
RAM 48648 48648 0 0.0
mcxw71+release FLASH 683008 683008 0 0.0
RAM 48648 48648 0 0.0
lock k32w1+release FLASH 705360 705360 0 0.0
RAM 67156 67156 0 0.0
mcxw71+release FLASH 705368 705368 0 0.0
RAM 67156 67156 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646292 1646292 0 0.0
RAM 210888 210888 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552356 1552356 0 0.0
RAM 207688 207688 0 0.0
light cy8ckit_062s2_43012 FLASH 1467828 1467828 0 0.0
RAM 200688 200688 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464900 1464900 0 0.0
RAM 225048 225048 0 0.0
qpg lighting-app qpg6105+debug FLASH 660488 660488 0 0.0
RAM 105236 105236 0 0.0
lock-app qpg6105+debug FLASH 618508 618508 0 0.0
RAM 99704 99704 0 0.0
stm32 light STM32WB5MM-DK FLASH 481784 481784 0 0.0
RAM 144684 144684 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620946 620946 0 0.0
RAM 50488 50488 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 688144 688144 0 0.0
RAM 148328 148328 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 781136 781136 0 0.0
RAM 110280 110280 0 0.0
bridge-app tlsr9258a FLASH 681042 681042 0 0.0
RAM 91144 91144 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620710 620710 0 0.0
RAM 50440 50440 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708652 708652 0 0.0
RAM 73780 73780 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625648 625648 0 0.0
RAM 144308 144308 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811408 811408 0 0.0
RAM 98940 98940 0 0.0
lock-app-dfu tlsr9528a FLASH 656616 656616 0 0.0
RAM 66500 66500 0 0.0
ota-requestor-app tlsr9258a FLASH 697020 697020 0 0.0
RAM 90736 90736 0 0.0
pump-app-usb tlsr9518adk80d FLASH 634344 634344 0 0.0
RAM 55316 55316 0 0.0
pump-controller-app tlsr9518adk80d FLASH 611534 611534 0 0.0
RAM 52560 52560 0 0.0
shell tlsr9518adk80d FLASH 467872 467872 0 0.0
RAM 68168 68168 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627860 627860 0 0.0
RAM 52160 52160 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653666 653666 0 0.0
RAM 56108 56108 0 0.0
thermostat tlsr9518adk80d FLASH 638266 638266 0 0.0
RAM 52952 52952 0 0.0
window-covering tlsr9118bdk40d FLASH 524404 524404 0 0.0
RAM 97284 97284 0 0.0
tizen all-clusters-app arm unknown 4904 4904 0 0.0
FLASH 1726732 1726732 0 0.0
RAM 89084 89084 0 0.0
chip-tool-ubsan arm unknown 10528 10528 0 0.0
FLASH 17718034 17718370 336 0.0
RAM 7714536 7714704 168 0.0

@yunhanw-google yunhanw-google merged commit 14e75a4 into project-chip:master Oct 10, 2024
70 checks passed
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@yunhanw-google @yyzhong-g
Store icdClientInfo after completing check-in message validation (pro…
cd84fc6 
…ject-chip#36026)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkardous-silabs mkardous-silabs mkardous-silabs approved these changes

@andy31415 andy31415 andy31415 approved these changes

Assignees
No one assigned
Labels
app icd Intermittently Connected Devices review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunhanw-google @andy31415 @mkardous-silabs