Remove python_lib build&test out of darwin build steps #35980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After project-chip#34892 this build is a noop so we do not benefit from running the build a 2nd time. This should save some CI time.
|
Review changes with SemanticDiff. |
|
PR #35980: Size comparison from 7fcc60f to 748b62f Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #35980: Size comparison from 7fcc60f to de9a080 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Oct 9, 2024
tcarmelveilleux
approved these changes
Oct 9, 2024
| BUILD_TYPE=$BUILD_TYPE scripts/tests/gn_tests.sh | ||
| done | ||
| - name: Ensure codegen is done for sanitize | ||
| # We want to build various standalone example apps similar to what examples-linux-standalone.yaml |
There was a problem hiding this comment.
The open paren here to match the close paren on the next line went away for some reason?
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…35980) * Remove python_lib build step completely. After project-chip#34892 this build is a noop so we do not benefit from running the build a 2nd time. This should save some CI time. * Update .github/workflows/build.yaml Co-authored-by: Boris Zbarsky <[email protected]> * Add back comments --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #34892 this build is a noop so we do not benefit from running the build a 2nd time.
This should save some CI time (this build and test currently runs in 1.5 hours ... if we actually do 2x the work like it seems we do, this may save 45 minutes of CI)