lighting-app: Remove OccupancySensing Server #35893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the OccupancySensing server from this app as this is against the spec and causes test_TC_IDM_10_1 to fail. With this change, now TC_DeviceBasicComposition.py passes for this example app.
|
Review changes with SemanticDiff. |
|
PR #35893: Size comparison from a1bafe1 to 26ecaf5 Full report (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #35893: Size comparison from 2651245 to c169a27 Full report (86 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35893: Size comparison from 2651245 to 0f4fc55 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Oct 3, 2024
arkq
approved these changes
Oct 4, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* lighting-app: Remove OccupancySensing Server This change removes the OccupancySensing server from this app as this is against the spec and causes test_TC_IDM_10_1 to fail. With this change, now TC_DeviceBasicComposition.py passes for this example app. * Remove OccupancySensing server from ESP32 example app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the OccupancySensing server from the
lighting-appas it's against the spec and causestest_TC_IDM_10_1to fail. With this change, nowTC_DeviceBasicComposition.pypasses for this example app.This change was made using the ZAP GUI tool (unticking the OccupancySensing server and saving) and then regenerating the zap config with
./scripts/tools/zap/generate.py examples/lighting-app/lighting-common/lighting-app.zapTest setup:
./out/linux-x64-light-no-ble/chip-lighting-apppython3 src/python_testing/TC_DeviceBasicComposition.py --commissioning-method on-network --qr-code MT:-24J0AFN00KA0648G00This test failed before and now passes.