[Fabric-Admin] Refactor to use API methods instead of PushCommand (2/3) #35867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #35867: Size comparison from 83159c2 to 4272595 Full report (86 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35867: Size comparison from 83159c2 to 2f1c8f7 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
reviewed
Oct 2, 2024
Co-authored-by: Terence Hampson <[email protected]>
Co-authored-by: Terence Hampson <[email protected]>
Co-authored-by: Terence Hampson <[email protected]>
Co-authored-by: Terence Hampson <[email protected]>
|
PR #35867: Size comparison from cc6c773 to 78aac89 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Oct 3, 2024
tehampson
approved these changes
Oct 3, 2024
|
PR #35867: Size comparison from cc6c773 to 6575f83 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…3) (project-chip#35867) * Refactor to use API methods instead of PushCommand for pairing * Restyled by whitespace * Restyled by clang-format * Schedule work on the Matter thread * Update examples/fabric-admin/device_manager/PairingManager.cpp Co-authored-by: Terence Hampson <[email protected]> * Update examples/fabric-admin/device_manager/PairingManager.cpp Co-authored-by: Terence Hampson <[email protected]> * Update examples/fabric-admin/device_manager/PairingManager.cpp Co-authored-by: Terence Hampson <[email protected]> * Update examples/fabric-admin/device_manager/PairingManager.cpp Co-authored-by: Terence Hampson <[email protected]> * Address review comments * Cleanup CCTRL attestation logic from PairingCommand --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Terence Hampson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Fabric-Admin example app, we currently use string-based command handling. To better integrate with the final product, we need to replace this with APIs that utilize the SDK's read, write, and invoke clients.
This is the second iteration of the migration process for pairing commands.
Fixes #34910