Add ability to report endpoint device types in the DataModel::Provider interface #35861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #35861: Size comparison from d404400 to 4082e6d Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35861: Size comparison from cd9cffb to c3d686c Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
src/app/codegen-data-model-provider/CodegenDataModelProvider.cpp
Outdated
Show resolved
Hide resolved
|
PR #35861: Size comparison from cd9cffb to d203154 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
Oct 2, 2024
src/app/codegen-data-model-provider/CodegenDataModelProvider.cpp
Outdated
Show resolved
Hide resolved
src/app/codegen-data-model-provider/CodegenDataModelProvider.cpp
Outdated
Show resolved
Hide resolved
|
PR #35861: Size comparison from cd9cffb to 7ae2c1b Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
approved these changes
Oct 3, 2024
|
PR #35861: Size comparison from cd9cffb to 53a0a24 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Oct 3, 2024
| /// - index == types.size() // i.e. not found or there is no next | ||
| /// | ||
| /// hintWherePreviousMayBe represents a search hint where previous may exist. | ||
| unsigned FindNextDeviceTypeIndex(Span<const EmberAfDeviceType> types, const DataModel::DeviceTypeEntry previous, |
There was a problem hiding this comment.
Why is this passing DeviceTypeEntry by value?
There was a problem hiding this comment.
Typo, will add a reference on monday
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…r interface (project-chip#35861) * Add separate listing for device types * Make unit tests work * Restyle * Fixup include * Fixup include * Add clang-tidy comments * Added a comment about future todo * more comments * Attempt to make the code more readable * Fix cast * Add comment for newly created issue. --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality seems used by our IM (specifically DeviceTypeResolver for access control selections.
Changes