[AddressResolver] Add a check in shutdown to avoid some crashes if so… #35824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meone calls it multiple times
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
andy31415
reviewed
Sep 27, 2024
andy31415
approved these changes
Sep 27, 2024
bzbarsky-apple
approved these changes
Sep 27, 2024
Co-authored-by: Andrei Litvin <[email protected]>
|
@vivien-apple could you update the summary to describe "what" applications do this? I can see an argument for the code to be tolerant to multiple shutdowns, however I would also have an argument that application behaviour should be well controlled and known. If they call shutdown multiple times, would they maybe call init multiple times? Should we guard the init as well or should we add logging when this out of order/extra calls are made? |
|
PR #35824: Size comparison from f509f67 to 8e2ed1d Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
project-chip#35824) * [AddressResolver] Add a check in shutdown to avoid some crashes if someone calls it multiple times * Apply suggestion from code review. Co-authored-by: Andrei Litvin <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…meone calls it multiple times
Problem
Some apps calls multiple times
Shutdownon the resolver and it crashes a bit after since it tries to access a null pointer. It won't hurt much to just null checkmSystemLayerand prevent doing the shutdown twice.