Define CI tests arguments in YAML format #35770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 9 of 10 files. Overall, the semantic diff is 35% smaller than the GitHub diff.
|
github-actions
bot
added
documentation
|
PR #35770: Size comparison from e9d7b2f to 56c61c1 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Sep 25, 2024
src/python_testing/matter_testing_infrastructure/chip/testing/metadata.py
Show resolved
Hide resolved
andy31415
reviewed
Sep 25, 2024
src/python_testing/matter_testing_infrastructure/chip/testing/metadata.py
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
Sep 25, 2024
@vatsalghelani-csa OK. Anyway, there should be no conflicts between your PR and this one (yours does not touch metadata.py, only moves it). Also, this PR is 100% backward compatible. However, we can coordinate the follow-up PR which will remove support for non-YAML syntax. Also, I'd like to somehow go forward with #35249 which together with this one will allow better wrapping for all |
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91 and
fessehaeve
pullapprove
bot
requested review from
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley,
mkardous-silabs,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
ReneJosefsen,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
|
PR #35770: Size comparison from e9d7b2f to 3b9f633 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
saurabhst
approved these changes
Sep 26, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Define CI tests arguments in YAML format * Convert ACE and ACL tests arguments to YAML * Update doc for CI test arguments * Restyled by prettier-markdown * Improve error reporting --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current format for CI test arguments is hard to read/modify in case when lots of arguments needs to be passed to the test script. Unfortunately, the format does not allow line breaks...
This PR proposes YAML as a format for defining CI test arguments. It is well-known and supports line breaks! For now, the YAML parser works alongside the old format, but the intention of this PR is to remove support for old format after migrating all test to YAML.
Changes
Testing
CI will verify