Removed using namespace std from all files #35741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
github-actions
bot
added
examples
setup payload
platform
lib
app
tizen
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
github-actions
bot
added
examples
setup payload
platform
lib
app
tizen
|
PR #35741: Size comparison from fbc0d21 to 9d5df91 Full report (22 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
jadhavrohit924
force-pushed
the
fix/ambiguity
branch
from
9d5df91 to
e9ac903
Compare
|
PR #35741: Size comparison from fbc0d21 to e9ac903 Full report (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #35741: Size comparison from fbc0d21 to e1fa3be Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35741: Size comparison from fbc0d21 to 8245330 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
requested changes
Sep 24, 2024
There was a problem hiding this comment.
The description in https://github.com/project-chip/connectedhomeip/blob/master/src/lib/support/TypeTraits.h#L32 seems to say we intentionally overloaded this to have C++23 shims.
Don't we have other alternatives? i.e. for C++23 just use the existingimplementation from the standard instead of implementing our own.
This PR seems to propose to have the workaround forever instead of treating it as a temporary shim.
jadhavrohit924
force-pushed
the
fix/ambiguity
branch
from
8653711 to
e342b2b
Compare
|
PR #35741: Size comparison from e9d7b2f to e342b2b Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Sep 25, 2024
|
PR #35741: Size comparison from e9d7b2f to 7613b1b Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
@andy31415 I have addressed the changes please take a look. |
andy31415
approved these changes
Sep 26, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Removed using namespace std from all files * Fix compilation * Found some more files were using namespace std * Fix TV app * Use std::to_underlying with c++23 and later * Addressed review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
using namespace stdcreates ambiguity error to C++23 standard compiler. #35713.Changes
Test