Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WaterHeater example fails TC_DEM_2.1 - ESAType not initialised #35688

Merged
merged 1 commit into from
Sep 20, 2024
Merged

WaterHeater example fails TC_DEM_2.1 - ESAType not initialised #35688

merged 1 commit into from
Sep 20, 2024

Conversation

jamesharrow
Copy link
Contributor

Fixes #35687 - Added missing initialization of ESAType to allow WaterHeater to pass TC_DEM_2.1

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@jamesharrow jamesharrow marked this pull request as ready for review September 19, 2024 22:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

PR #35688: Size comparison from 8318df9 to 5d69f42

Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 8318df9 5d69f42 change % change
bl602 lighting-app bl602 FLASH 1280006 1280006 0 0.0
RAM 95848 95848 0 0.0
bl602+mfd FLASH 1294128 1294128 0 0.0
RAM 95992 95992 0 0.0
bl602+rpc FLASH 1319218 1319218 0 0.0
RAM 104272 104272 0 0.0
bl702 lighting-app bl702 FLASH 944122 944122 0 0.0
RAM 15145 15145 0 0.0
bl702+mfd FLASH 946522 946522 0 0.0
RAM 15305 15305 0 0.0
bl702+rpc FLASH 1039442 1039442 0 0.0
RAM 24173 24173 0 0.0
bl706-eth FLASH 646318 646318 0 0.0
RAM 25233 25233 0 0.0
bl706-wifi FLASH 894398 894398 0 0.0
RAM 14477 14477 0 0.0
bl702l lighting-app bl702l FLASH 960782 960782 0 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 963404 963404 0 0.0
RAM 16964 16964 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 677629 677629 0 0.0
RAM 78516 78516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 697481 697481 0 0.0
RAM 81148 81148 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 697481 697481 0 0.0
RAM 81148 81148 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 654409 654409 0 0.0
RAM 73584 73584 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613669 613669 0 0.0
RAM 71468 71468 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633297 633297 0 0.0
RAM 74020 74020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633297 633297 0 0.0
RAM 74020 74020 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 632925 632925 0 0.0
RAM 74516 74516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652633 652633 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652633 652633 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608333 608333 0 0.0
RAM 68604 68604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 628193 628193 0 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 628193 628193 0 0.0
RAM 71236 71236 0 0.0
efr32 lighting-app BRD4187C FLASH 932732 932732 0 0.0
RAM 135080 135080 0 0.0
lock-app BRD2605a FLASH 740520 740512 -8 -0.0
RAM 231220 231220 0 0.0
BRD4338a FLASH 741168 741160 -8 -0.0
RAM 231252 231252 0 0.0
window-app BRD4187C FLASH 1016080 1016072 -8 -0.0
RAM 127004 127004 0 0.0
esp32 all-clusters-app c3devkit DRAM 94080 94080 0 0.0
FLASH 1537382 1537382 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115032 115032 0 0.0
FLASH 1547822 1547822 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2764229 2764229 0 0.0
RAM 129424 129424 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6067718 6067718 0 0.0
RAM 507360 507360 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5401050 5401050 0 0.0
RAM 241136 241136 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4734606 4734606 0 0.0
RAM 218304 218304 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12545884 12545884 0 0.0
RAM 555058 555058 0 0.0
chip-tool-ipv6only arm64 unknown 20424 20424 0 0.0
FLASH 11253520 11253520 0 0.0
RAM 605288 605288 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 10904383 10904383 0 0.0
RAM 554234 554234 0 0.0
fabric-bridge-app debug unknown 4640 4640 0 0.0
FLASH 4557266 4557266 0 0.0
RAM 204888 204888 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5670849 5670849 0 0.0
RAM 228560 228560 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4783810 4783810 0 0.0
RAM 204376 204376 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4416994 4416994 0 0.0
RAM 198112 198112 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4555742 4555742 0 0.0
RAM 202680 202680 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3094925 3094925 0 0.0
RAM 159184 159184 0 0.0
thermostat-no-ble arm64 unknown 9416 9416 0 0.0
FLASH 4337392 4337392 0 0.0
RAM 242808 242808 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6012949 6012949 0 0.0
RAM 580896 580896 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10739453 10739453 0 0.0
RAM 642976 642976 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913308 913308 0 0.0
RAM 142199 142199 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 884992 884992 0 0.0
RAM 140338 140338 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846820 846820 0 0.0
RAM 141093 141093 0 0.0
nxp contact k32w0+release FLASH 581760 581760 0 0.0
RAM 70776 70776 0 0.0
k32w1+release FLASH 594232 594232 0 0.0
RAM 62944 62944 0 0.0
mcxw71+release FLASH 593992 593992 0 0.0
RAM 62944 62944 0 0.0
light k32w0+release FLASH 617652 617652 0 0.0
RAM 70248 70248 0 0.0
k32w1+release FLASH 680880 680880 0 0.0
RAM 48584 48584 0 0.0
mcxw71+release FLASH 680896 680896 0 0.0
RAM 48584 48584 0 0.0
lock k32w1+release FLASH 702856 702856 0 0.0
RAM 67084 67084 0 0.0
mcxw71+release FLASH 702880 702880 0 0.0
RAM 67084 67084 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1645124 1645124 0 0.0
RAM 210888 210888 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1551124 1551124 0 0.0
RAM 207688 207688 0 0.0
light cy8ckit_062s2_43012 FLASH 1466940 1466940 0 0.0
RAM 200696 200696 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463572 1463572 0 0.0
RAM 225048 225048 0 0.0
qpg lighting-app qpg6105+debug FLASH 659384 659384 0 0.0
RAM 105236 105236 0 0.0
lock-app qpg6105+debug FLASH 617268 617268 0 0.0
RAM 99704 99704 0 0.0
stm32 light STM32WB5MM-DK FLASH 480920 480920 0 0.0
RAM 144692 144692 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 621958 621958 0 0.0
RAM 50988 50988 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687200 687200 0 0.0
RAM 148328 148328 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 780144 780144 0 0.0
RAM 110780 110780 0 0.0
bridge-app tlsr9258a FLASH 680980 680980 0 0.0
RAM 91644 91644 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621722 621722 0 0.0
RAM 50940 50940 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707630 707630 0 0.0
RAM 74280 74280 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 624878 624878 0 0.0
RAM 144316 144316 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 810286 810286 0 0.0
RAM 99448 99448 0 0.0
lock-app-dfu tlsr9528a FLASH 655476 655476 0 0.0
RAM 67000 67000 0 0.0
ota-requestor-app tlsr9258a FLASH 696956 696956 0 0.0
RAM 91236 91236 0 0.0
pump-app-usb tlsr9518adk80d FLASH 633312 633312 0 0.0
RAM 55816 55816 0 0.0
pump-controller-app tlsr9518adk80d FLASH 610502 610502 0 0.0
RAM 53060 53060 0 0.0
shell tlsr9518adk80d FLASH 467192 467192 0 0.0
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628688 628688 0 0.0
RAM 52660 52660 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652638 652638 0 0.0
RAM 56608 56608 0 0.0
thermostat tlsr9518adk80d FLASH 637232 637232 0 0.0
RAM 53452 53452 0 0.0
window-covering tlsr9118bdk40d FLASH 523408 523408 0 0.0
RAM 97284 97284 0 0.0
tizen all-clusters-app arm unknown 4876 4876 0 0.0
FLASH 1721872 1721872 0 0.0
RAM 89084 89084 0 0.0
chip-tool-ubsan arm unknown 10312 10312 0 0.0
FLASH 17348306 17348306 0 0.0
RAM 7558408 7558408 0 0.0

@mergify mergify bot merged commit 4842bfc into project-chip:master Sep 20, 2024
67 checks passed
@jamesharrow jamesharrow deleted the 35687-cert-test-failure-when-testing-tc_dem_21-with-waterheater-example-the-esa-type-was-evse branch September 21, 2024 08:09
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@jamesharrow @yyzhong-g
Fixes project-chip#35687 - Added missing initialization of ESAType to…
286f8c0 
… allow WaterHeater to pass TC_DEM_2.1 (project-chip#35688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpbeliveau-silabs lpbeliveau-silabs lpbeliveau-silabs approved these changes

@andy31415 andy31415 andy31415 approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtov-sfy jtov-sfy Awaiting requested review from jtov-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CERT-TEST-FAILURE] When testing TC_DEM_2.1 with WaterHeater example, the ESA Type was EVSE
3 participants
@jamesharrow @andy31415 @lpbeliveau-silabs