[RMP] Update the logs produce by the reliable message manager #35649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
pullapprove
bot
added
review - pending
messaging
protocols
and removed
messaging
protocols
labels
|
PR #35649: Size comparison from 2396bb4 to 54216ef Full report (39 builds for linux, nrfconnect, stm32, telink, tizen)
|
vivien-apple
force-pushed
the
RMP_UpdateLogFormat
branch
from
54216ef to
7779c86
Compare
|
PR #35649: Size comparison from afb1a33 to 7779c86 Full report (39 builds for linux, nrfconnect, stm32, telink, tizen)
|
vivien-apple
force-pushed
the
RMP_UpdateLogFormat
branch
from
7779c86 to
6bda8b1
Compare
vivien-apple
force-pushed
the
RMP_UpdateLogFormat
branch
2 times, most recently
from
23a87ba to
9afb83d
Compare
|
PR #35649: Size comparison from 8f7d74d to 9afb83d Full report (14 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
vivien-apple
force-pushed
the
RMP_UpdateLogFormat
branch
2 times, most recently
from
2af1f4b to
99b3f42
Compare
vivien-apple
force-pushed
the
RMP_UpdateLogFormat
branch
from
99b3f42 to
6c29685
Compare
|
PR #35649: Size comparison from b31673f to 6c29685 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Sep 30, 2024
|
Fast tracking this, given this has had 2 weeks for review, and is blocking some quality tests passing. |
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…t-chip#35649) * [MRP] Log target retransmission time for a given session/exchange * [MRP] Log the local MRP values used when establishing a PASE or a CASE session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is not obvious to know which values are used with RMP, both for the local RMP values and the remote values.
This PR updates the code such that:
For what it worth those logs has allowed me to find an issue (issue # to come)