Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libfuzzer] Fuzzing different Transport Types for all-clusters-app #35629

Merged
merged 5 commits into from
Sep 19, 2024
Merged

[libfuzzer] Fuzzing different Transport Types for all-clusters-app #35629

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
04789a3
Fuzzing different Transport Types for all-clusters-app
Alami-Amine Sep 17, 2024
b46ce9f
Adding an enum value for the number of transport types
Alami-Amine Sep 18, 2024
a3d0fb7
1. replacing magic number when fuzzing the number of transport types
Alami-Amine Sep 18, 2024
8f17d3b
Restyled by clang-format
restyled-commits Sep 18, 2024
fec7b49
avoiding out of bounds access
Alami-Amine Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions examples/all-clusters-app/linux/fuzzing-main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,19 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t * aData, size_t aSize)
// For now, just dump the data as a UDP payload into the session manager.
// But maybe we should try to separately extract a PeerAddress and data from
// the incoming data?
Transport::PeerAddress peerAddr;

// dumping payload with fuzzed transport types
constexpr uint8_t numberOfTypes = static_cast<int>(Transport::Type::kLast) + 1;
Transport::Type fuzzedTransportType = static_cast<Transport::Type>(aData[0] % numberOfTypes);
Transport::PeerAddress peerAddr(fuzzedTransportType);

if (aSize < 1)
Alami-Amine marked this conversation as resolved.
Show resolved Hide resolved
{
return 0;
}

System::PacketBufferHandle buf =
System::PacketBufferHandle::NewWithData(aData, aSize, /* aAdditionalSize = */ 0, /* aReservedSize = */ 0);
System::PacketBufferHandle::NewWithData(&aData[1], aSize - 1, /* aAdditionalSize = */ 0, /* aReservedSize = */ 0);
if (buf.IsNull())
{
// Too big; we couldn't represent this as a packetbuffer to start with.
Expand All @@ -84,8 +94,17 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t * aData, size_t aSize)

// Ignoring the return value from OnMessageReceived, because we might be
// passing it all sorts of garbage that will cause it to fail.
Server::GetInstance().GetSecureSessionManager().OnMessageReceived(peerAddr, std::move(buf));

// for TCP we need to have MessageTransportContext
if (fuzzedTransportType == Transport::Type::kTcp)
{
Transport::MessageTransportContext msgContext;
bzbarsky-apple marked this conversation as resolved.
Show resolved Hide resolved
Server::GetInstance().GetSecureSessionManager().OnMessageReceived(peerAddr, std::move(buf), &msgContext);
}
else
{
Server::GetInstance().GetSecureSessionManager().OnMessageReceived(peerAddr, std::move(buf));
}
// Now process pending events until our sentinel is reached.
PlatformMgr().ScheduleWork([](intptr_t) { PlatformMgr().StopEventLoopTask(); });
PlatformMgr().RunEventLoop();
Expand Down
1 change: 1 addition & 0 deletions src/transport/raw/PeerAddress.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ enum class Type : uint8_t
kBle,
kTcp,
kWiFiPAF,
kLast = kWiFiPAF, // This is not an actual transport type, it just refers to the last transport type
};

/**
Expand Down
Loading