[NXP] Move some components in common #35594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: marius-alex-tache <[email protected]>
Signed-off-by: marius-alex-tache <[email protected]>
This can be reused by other platforms as long as they are using the same SDK. Signed-off-by: marius-alex-tache <[email protected]>
OTAFirmwareProcessor and OTAHooks could be reused by other platforms as long as the SDK is the same, so moving them from k32w1 folder. Signed-off-by: marius-alex-tache <[email protected]>
Some components were implemented for k32w1, but can be reused as long as the used SDK is the same. Moving them to factory_data/legacy until synchronizing with the other factory data implementation. Signed-off-by: marius-alex-tache <[email protected]>
Signed-off-by: marius-alex-tache <[email protected]>
|
Review changes with SemanticDiff. Analyzed 1 of 51 files. File Information
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran and
hawk248
pullapprove
bot
requested review from
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
doru91
added
the
changing-submodules-on-purpose
Signed-off-by: marius-alex-tache <[email protected]>
Signed-off-by: marius-alex-tache <[email protected]>
…ge OTA Signed-off-by: marius-alex-tache <[email protected]>
Signed-off-by: marius-alex-tache <[email protected]>
…omponents Signed-off-by: marius-alex-tache <[email protected]>
Signed-off-by: Doru Gucea <[email protected]>
Signed-off-by: marius-alex-tache <[email protected]>
marius-alex-tache
force-pushed
the
move-some-components-in-common
branch
from
bb3a345 to
b215269
Compare
|
PR #35594: Size comparison from ba9faf2 to cd4d106 Increases above 0.2%:
Full report (47 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
k32w0_sdk_root set was moved to nxp_matter_support submodule Signed-off-by: Marius Tache <[email protected]>
|
PR #35594: Size comparison from ba9faf2 to 96a88c2 Increases above 0.2%:
Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
doru91
approved these changes
Sep 16, 2024
saurabhst
approved these changes
Sep 17, 2024
arkq
approved these changes
Sep 17, 2024
dinabenamar
pushed a commit
to NXP/matter
that referenced
this pull request
Oct 24, 2024
* [nxp][platform][common] Rename S200 crypto PAL and move it to common Signed-off-by: marius-alex-tache <[email protected]> * [nxp][examples][common] Make S200 Operational Keystore common Signed-off-by: marius-alex-tache <[email protected]> * [nxp][platform][common] Make k32w1 BLEManager implementation common This can be reused by other platforms as long as they are using the same SDK. Signed-off-by: marius-alex-tache <[email protected]> * [nxp][platform][common] Move OTA related files to a common folder OTAFirmwareProcessor and OTAHooks could be reused by other platforms as long as the SDK is the same, so moving them from k32w1 folder. Signed-off-by: marius-alex-tache <[email protected]> * [nxp][platform][common] Move Factory Data provider into a common folder Some components were implemented for k32w1, but can be reused as long as the used SDK is the same. Moving them to factory_data/legacy until synchronizing with the other factory data implementation. Signed-off-by: marius-alex-tache <[email protected]> * [nxp][platform][k32w0] Update files after moving some components Signed-off-by: marius-alex-tache <[email protected]> * [nxp][mcxw71_k32w1] Update build system after moving some components Signed-off-by: marius-alex-tache <[email protected]> * [nxp][examples][k32w0] Update build system after moving some components Signed-off-by: marius-alex-tache <[email protected]> * [nxp][scripts][common] Update list of supported devices for multi-image OTA Signed-off-by: marius-alex-tache <[email protected]> * [nxp] Bump nxp_matter_support Signed-off-by: marius-alex-tache <[email protected]> * [nxp][mcxw71_k32w1][lock-app] Update build system after moving some components Signed-off-by: marius-alex-tache <[email protected]> * [nxp][mcxw71_k32w1] Fix factory data compilation issue Signed-off-by: Doru Gucea <[email protected]> * Restyled by gn * [nxp][ota] Fix spelling of platforms Signed-off-by: marius-alex-tache <[email protected]> * Restyled by gn * [nxp][platform][k32w0] Move setting of k32w0_sdk_root k32w0_sdk_root set was moved to nxp_matter_support submodule Signed-off-by: Marius Tache <[email protected]> --------- Signed-off-by: marius-alex-tache <[email protected]> Signed-off-by: Doru Gucea <[email protected]> Signed-off-by: Marius Tache <[email protected]> Co-authored-by: Doru Gucea <[email protected]> Co-authored-by: Restyled.io <[email protected]> (cherry picked from commit 89c8d33)
dinabenamar
pushed a commit
to NXP/matter
that referenced
this pull request
Oct 24, 2024
…chip#35594)" This reverts commit a704832. Signed-off-by: Gatien Chapon <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* [nxp][platform][common] Rename S200 crypto PAL and move it to common Signed-off-by: marius-alex-tache <[email protected]> * [nxp][examples][common] Make S200 Operational Keystore common Signed-off-by: marius-alex-tache <[email protected]> * [nxp][platform][common] Make k32w1 BLEManager implementation common This can be reused by other platforms as long as they are using the same SDK. Signed-off-by: marius-alex-tache <[email protected]> * [nxp][platform][common] Move OTA related files to a common folder OTAFirmwareProcessor and OTAHooks could be reused by other platforms as long as the SDK is the same, so moving them from k32w1 folder. Signed-off-by: marius-alex-tache <[email protected]> * [nxp][platform][common] Move Factory Data provider into a common folder Some components were implemented for k32w1, but can be reused as long as the used SDK is the same. Moving them to factory_data/legacy until synchronizing with the other factory data implementation. Signed-off-by: marius-alex-tache <[email protected]> * [nxp][platform][k32w0] Update files after moving some components Signed-off-by: marius-alex-tache <[email protected]> * [nxp][mcxw71_k32w1] Update build system after moving some components Signed-off-by: marius-alex-tache <[email protected]> * [nxp][examples][k32w0] Update build system after moving some components Signed-off-by: marius-alex-tache <[email protected]> * [nxp][scripts][common] Update list of supported devices for multi-image OTA Signed-off-by: marius-alex-tache <[email protected]> * [nxp] Bump nxp_matter_support Signed-off-by: marius-alex-tache <[email protected]> * [nxp][mcxw71_k32w1][lock-app] Update build system after moving some components Signed-off-by: marius-alex-tache <[email protected]> * [nxp][mcxw71_k32w1] Fix factory data compilation issue Signed-off-by: Doru Gucea <[email protected]> * Restyled by gn * [nxp][ota] Fix spelling of platforms Signed-off-by: marius-alex-tache <[email protected]> * Restyled by gn * [nxp][platform][k32w0] Move setting of k32w0_sdk_root k32w0_sdk_root set was moved to nxp_matter_support submodule Signed-off-by: Marius Tache <[email protected]> --------- Signed-off-by: marius-alex-tache <[email protected]> Signed-off-by: Doru Gucea <[email protected]> Signed-off-by: Marius Tache <[email protected]> Co-authored-by: Doru Gucea <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing some folder restructure by moving a couple of
k32w1components from the platform specific device layer to a common NXP location. These components can be reused by other platforms.Changelog:
nxp_matter_supportsubmodulek32w1andmcxw71NXP reference apps