-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --zap ZAP
to run_zaptool.sh
to Specify an Arbitrary Location to zap
#35582
Merged
mergify
merged 2 commits into
project-chip:master
from
Nuovations:user/gerickson/github-issue-35549-run_zaptool.sh-specify-zap-executable
Sep 13, 2024
Merged
Add --zap ZAP
to run_zaptool.sh
to Specify an Arbitrary Location to zap
#35582
mergify
merged 2 commits into
project-chip:master
from
Nuovations:user/gerickson/github-issue-35549-run_zaptool.sh-specify-zap-executable
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. |
github-actions
bot
added
documentation
Improvements or additions to documentation
scripts
labels
Sep 13, 2024
gerickson
force-pushed
the
user/gerickson/github-issue-35549-run_zaptool.sh-specify-zap-executable
branch
from
September 13, 2024 17:40
1b5fee9
to
07d99e2
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
September 13, 2024 17:41
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
September 13, 2024 17:41
PR #35582: Size comparison from 236908d to 07d99e2 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Sep 13, 2024
…to `zap` (project-chip#35549). * scripts/tools/zap/run_zaptool.sh * Display the value of 'ZAP_CMD' to standard output. * Add support for the `--zap` command line option to specify the `zap` executable to run. * Added usage documentation about `ZAP_DEVELOPMENT_PATH` and `ZAP_INSTALL_PATH`. * docs/code_generation.md: Added documentation about the `--zap ZAP` option to `run_zaptool.sh`.
gerickson
force-pushed
the
user/gerickson/github-issue-35549-run_zaptool.sh-specify-zap-executable
branch
from
September 13, 2024 20:38
07d99e2
to
3c63ad3
Compare
…ool.sh-specify-zap-executable
PR #35582: Size comparison from bba766b to 6fdd88a Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Sep 13, 2024
gerickson
deleted the
user/gerickson/github-issue-35549-run_zaptool.sh-specify-zap-executable
branch
September 13, 2024 23:07
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…to `zap` (project-chip#35549). (project-chip#35582) * scripts/tools/zap/run_zaptool.sh * Display the value of 'ZAP_CMD' to standard output. * Add support for the `--zap` command line option to specify the `zap` executable to run. * Added usage documentation about `ZAP_DEVELOPMENT_PATH` and `ZAP_INSTALL_PATH`. * docs/code_generation.md: Added documentation about the `--zap ZAP` option to `run_zaptool.sh`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--zap ZAP
torun_zaptool.sh
to Specify an Arbitrary Location tozap
(#35549).ZAP_CMD
to standard output.--zap
command line option to specify thezap
executable to run.ZAP_DEVELOPMENT_PATH
andZAP_INSTALL_PATH
.--zap ZAP
option torun_zaptool.sh
.