[Silabs] Increase the max supported KVS entries #35480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
jmartinez-silabs
added
the
changing-submodules-on-purpose
pullapprove
bot
added
review - pending
and removed
changing-submodules-on-purpose
jmartinez-silabs
force-pushed
the
feature/increase_kvs_entries
branch
from
bc52e7d to
8081114
Compare
|
PR #35480: Size comparison from bbc5248 to 8081114 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35480: Size comparison from 7d57f07 to 0ac8eed Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Sep 9, 2024
kiel-apple
added
the
changing-submodules-on-purpose
|
PR #35480: Size comparison from 83d345e to bddae82 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
rcasallas-silabs
approved these changes
Sep 10, 2024
fuxiaoming-lumi
added a commit
to fuxiaoming-lumi/connectedhomeip
that referenced
this pull request
Sep 23, 2024
Add two new gn arg(sl_nvm3_nvm_size and sl_nvm3_cache_size) to configure NVM3. Developers can analyze their storage needs to adjust these two parameters, which can effectively improve storage efficiency. Especially after project-chip#35480, developers would like to adjust these configuration.
jmartinez-silabs
pushed a commit
that referenced
this pull request
Sep 23, 2024
Add two new gn arg(sl_nvm3_nvm_size and sl_nvm3_cache_size) to configure NVM3. Developers can analyze their storage needs to adjust these two parameters, which can effectively improve storage efficiency. Especially after #35480, developers would like to adjust these configuration.
ArekBalysNordic
pushed a commit
to ArekBalysNordic/sdk-connectedhomeip
that referenced
this pull request
Nov 28, 2024
Add two new gn arg(sl_nvm3_nvm_size and sl_nvm3_cache_size) to configure NVM3. Developers can analyze their storage needs to adjust these two parameters, which can effectively improve storage efficiency. Especially after project-chip/connectedhomeip#35480, developers would like to adjust these configuration.
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Increase the maximum KVS entries our implementation can handle * add gn argument to configure the nvm3 max object size
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
Add two new gn arg(sl_nvm3_nvm_size and sl_nvm3_cache_size) to configure NVM3. Developers can analyze their storage needs to adjust these two parameters, which can effectively improve storage efficiency. Especially after project-chip#35480, developers would like to adjust these configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tweaks to our KVS implementation to support more entries (up to 511 entries from 255).
The default stays at 255 but can be increased with the gn arg
kvs_max_entriesAlso, add a new gn arg (
sl_nvm3_max_object_size) to configure the nvm3 storage max size for a single entry. The default is 4092 as it is the absolute maximal value of the driver.Users should analyze their storage needs and reduce the nvm3_max_object_size to the lowest amount possible (~ size of their largest stored object) to increase the efficiency of the nvm3 storage section.