Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DishWasher Mode Cluster StartUpMode and OnMode attributes are marked as provisional in spec #35479

Closed
wants to merge 4 commits into from
Closed

DishWasher Mode Cluster StartUpMode and OnMode attributes are marked as provisional in spec #35479

wants to merge 4 commits into from

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Sep 9, 2024 •
edited
Loading

In DishWasher Mode Cluster StartUpMode and OnMode attributes are marked as provisional in spec.

In connection with this issue: [Dish Washer Mode] Sample app(All-cluster-app) has to be updated by removing the provisional Attributes #34129

@lboue
Update dishwasher-mode-cluster.xml
7bbcfba 
In `DishWasher Mode` Cluster `StartUpMode` and `OnMode` attributes are marked as provisional in spec.
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@github-actions github-actions bot added the app label Sep 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

PR #35479: Size comparison from 607a4a8 to 7bbcfba

Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
platform target config section 607a4a8 7bbcfba change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914064 914064 0 0.0
RAM 142252 142252 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885732 885732 0 0.0
RAM 140391 140391 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845456 845456 0 0.0
RAM 141070 141070 0 0.0
nxp contact k32w0+release FLASH 579500 579500 0 0.0
RAM 70676 70676 0 0.0
k32w1+release FLASH 593328 593328 0 0.0
RAM 62712 62712 0 0.0
light k32w0+release FLASH 615128 615128 0 0.0
RAM 70140 70140 0 0.0
k32w1+release FLASH 676952 676952 0 0.0
RAM 47848 47848 0 0.0
qpg lighting-app qpg6105+debug FLASH 657804 657804 0 0.0
RAM 105192 105192 0 0.0
lock-app qpg6105+debug FLASH 615960 615960 0 0.0
RAM 99660 99660 0 0.0
stm32 light STM32WB5MM-DK FLASH 481608 481608 0 0.0
RAM 144740 144740 0 0.0
tizen all-clusters-app arm unknown 4840 4840 0 0.0
FLASH 1722416 1722416 0 0.0
RAM 89548 89548 0 0.0
chip-tool-ubsan arm unknown 10276 10276 0 0.0
FLASH 17501346 17501346 0 0.0
RAM 7597300 7597300 0 0.0

@lboue
Update controller-clusters.matter
59a0f6c 
`DishWasher Mode` Cluster `StartUpMode` and `OnMode` attributes attributes are provisional in spec
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

PR #35479: Size comparison from 607a4a8 to 59a0f6c

Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
platform target config section 607a4a8 59a0f6c change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914064 914064 0 0.0
RAM 142252 142252 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885732 885732 0 0.0
RAM 140391 140391 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845456 845456 0 0.0
RAM 141070 141070 0 0.0
nxp contact k32w0+release FLASH 579500 579500 0 0.0
RAM 70676 70676 0 0.0
k32w1+release FLASH 593328 593328 0 0.0
RAM 62712 62712 0 0.0
light k32w0+release FLASH 615128 615128 0 0.0
RAM 70140 70140 0 0.0
k32w1+release FLASH 676952 676952 0 0.0
RAM 47848 47848 0 0.0
qpg lighting-app qpg6105+debug FLASH 657804 657804 0 0.0
RAM 105192 105192 0 0.0
lock-app qpg6105+debug FLASH 615960 615960 0 0.0
RAM 99660 99660 0 0.0
stm32 light STM32WB5MM-DK FLASH 481608 481608 0 0.0
RAM 144740 144740 0 0.0
tizen all-clusters-app arm unknown 4840 4840 0 0.0
FLASH 1722416 1722416 0 0.0
RAM 89548 89548 0 0.0
chip-tool-ubsan arm unknown 10276 10276 0 0.0
FLASH 17501346 17501346 0 0.0
RAM 7597300 7597300 0 0.0

@lboue
Update all-clusters-app.zap
9a83b8b 
`DishWasher Mode` Cluster `StartUpMode` and `OnMode` attributes attributes are provisional in spec. So it should be removed from the Sample app(All-cluster-app).
@lboue
Update all-clusters-app.matter
57511dd 
`DishWasher Mode` Cluster `StartUpMode` and `OnMode` attributes attributes are provisional in spec
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

PR #35479: Size comparison from 607a4a8 to 57511dd

Full report (20 builds for bl602, bl702, bl702l, efr32, nxp, qpg, stm32)
platform target config section 607a4a8 57511dd change % change
bl602 lighting-app bl602 FLASH 1279600 1279600 0 0.0
RAM 95904 95904 0 0.0
bl602+mfd FLASH 1293708 1293708 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1318564 1318564 0 0.0
RAM 104328 104328 0 0.0
bl702 lighting-app bl702 FLASH 944934 944934 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 947332 947332 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1040246 1040246 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 648006 648006 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 895420 895420 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 961594 961594 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 964214 964214 0 0.0
RAM 17012 17012 0 0.0
efr32 lighting-app BRD4187C FLASH 933684 933684 0 0.0
RAM 135120 135120 0 0.0
lock-app BRD4338a FLASH 740804 740804 0 0.0
RAM 197184 197184 0 0.0
window-app BRD4187C FLASH 1017480 1017472 -8 -0.0
RAM 127060 127060 0 0.0
nxp contact k32w0+release FLASH 579500 579500 0 0.0
RAM 70676 70676 0 0.0
k32w1+release FLASH 593328 593328 0 0.0
RAM 62712 62712 0 0.0
light k32w0+release FLASH 615128 615128 0 0.0
RAM 70140 70140 0 0.0
k32w1+release FLASH 676952 676952 0 0.0
RAM 47848 47848 0 0.0
qpg lighting-app qpg6105+debug FLASH 657804 657804 0 0.0
RAM 105192 105192 0 0.0
lock-app qpg6105+debug FLASH 615960 615960 0 0.0
RAM 99660 99660 0 0.0
stm32 light STM32WB5MM-DK FLASH 481608 481608 0 0.0
RAM 144740 144740 0 0.0

@lboue lboue closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app controller examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lboue