-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encourage the use of CopyCharSpanToMutableCharSpanWithTruncation #35444
Conversation
…arSpanToMutableCharSpanWithTruncation for memory safety. Updated the rvc-app example to use this method.
Review changes with SemanticDiff. |
PR #35444: Size comparison from 0b696d8 to 1fddb2b Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but note that truncation can produce interesting garbage at the truncation point in languages other than English where the UTF-8 encoding of characters is multi-byte....
PR #35444: Size comparison from edf1f65 to 51c437f Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…ject-chip#35444) * Updated the service area documentation to encourage the use of CopyCharSpanToMutableCharSpanWithTruncation for memory safety. Updated the rvc-app example to use this method. * Restyled by whitespace --------- Co-authored-by: Restyled.io <[email protected]>
CopyCharSpanToMutableCharSpanWithTruncation
in methods that do not provide a way propagate errors.CopyCharSpanToMutableCharSpanWithTruncation
.