[Chef] Fix invalid featureMap and associated commands/attributes in colortemperaturelight ZAP #35443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #35443: Size comparison from f89d5b9 to 1fb6b67 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.zap
Outdated
Show resolved
Hide resolved
examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.zap
Outdated
Show resolved
Hide resolved
examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.zap
Outdated
Show resolved
Hide resolved
examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.zap
Outdated
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Sep 6, 2024
andy31415
previously requested changes
Sep 6, 2024
There was a problem hiding this comment.
This PR needs a summary to describe the changes. Fix colortemperaturelight is insufficient.
What was fixed and why? Why was it broken and why is the fix correct or why was the proposed fix path taken?
In general would like to undersatnd why:
- things moved from ram to persist
- various attributes gone
- various defaults updated
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248 and
hicklin
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
|
PR #35443: Size comparison from 607a4a8 to 3e577d2 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
@andy31415 The description of this PR was updated. PTAL |
erwinpan1
changed the title
|
PR #35443: Size comparison from 607a4a8 to fc11d7b Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Sep 10, 2024
|
PR #35443: Size comparison from 3f0f242 to 514b2f6 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
erwinpan1
added a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Sep 13, 2024
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Sep 20, 2024
…olortemperaturelight ZAP (project-chip#35443) * Fix chef colortemperaturelight ZAP * Not changing the default value of the CoupleColorTempToLevelMinMireds * Fix ColorTemperatureMired range 0x9A~0x1C6
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…olortemperaturelight ZAP (project-chip#35443) * Fix chef colortemperaturelight ZAP * Not changing the default value of the CoupleColorTempToLevelMinMireds * Fix ColorTemperatureMired range 0x9A~0x1C6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set the clusters to correct feature bits (e.g.
On/Off clusterto0x1to enableLT,LevelControlto0x3to enableOnOffandLighting,Color Controlcluster to0x10to enableColorTemperature)After correcting the featuremap above, remove all the non-relevant attributes / commands (e.g.
MoveHuecommand orPrimary 1Xattribute)Set the default values for some attributes to either the minimum or maximum of their possible range.
Moved attributes from RAM to Persistent since we found the attribute changes will be gone after device reboot (without factory reset).