[ESP32] Add an option to set default log level for CHIP logs. #35442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
|
|
PR #35442: Size comparison from f89d5b9 to a2f0b08 Full report (10 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
ChinmayLonkar
force-pushed
the
feat/add_chip_log_level_opt
branch
from
a2f0b08 to
0465a3a
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
pullapprove
bot
requested review from
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #35442: Size comparison from f89d5b9 to 0465a3a Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ChinmayLonkar
force-pushed
the
feat/add_chip_log_level_opt
branch
2 times, most recently
from
7434e92 to
b5e0e55
Compare
|
PR #35442: Size comparison from 0b696d8 to b5e0e55 Full report (39 builds for bl602, bl702, bl702l, cyw30739, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
ChinmayLonkar
force-pushed
the
feat/add_chip_log_level_opt
branch
2 times, most recently
from
82bc67c to
1693b7a
Compare
|
PR #35442: Size comparison from 0b696d8 to 1693b7a Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Sep 7, 2024
shubhamdp
approved these changes
Sep 9, 2024
ChinmayLonkar
force-pushed
the
feat/add_chip_log_level_opt
branch
from
1693b7a to
ef9cb1b
Compare
|
PR #35442: Size comparison from 7249c56 to ef9cb1b Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
dhrishi
approved these changes
Sep 9, 2024
ChinmayLonkar
force-pushed
the
feat/add_chip_log_level_opt
branch
from
ef9cb1b to
2f78346
Compare
|
PR #35442: Size comparison from f7536b6 to 2f78346 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Sep 11, 2024
mergify bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
…#35532) Co-authored-by: Chinmay Lonkar <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview:
Add
CHIP_LOG_DEFAULT_LEVELoption to enhance logging flexibility and optimise memory usage, this option would allow users to set a specific log level threshold for CHIP logs, effectively controlling the verbosity of log output.This would optimise memory by setting a lower CHIP log level , users can reduce the amount of log data generated, potentially saving significant memory in resource-constrained devices.
Testing
Tested the lighting-app esp32 by changing the CHIP logs levels and trying out commissioning.