Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating XPC interfaces to pass along context, and fixing some retries #35441

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Updating XPC interfaces to pass along context, and fixing some retries #35441

merged 5 commits into from
Sep 6, 2024

Conversation

woody-apple
Copy link
Contributor

@woody-apple woody-apple commented Sep 6, 2024 •
edited
Loading

• XPC clients were not retrying, there is still an issue, but moving forward with this for now.
• Internal state was not propagating
• New delegate was being used, going back to normal one

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@github-actions github-actions bot added the darwin label Sep 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

PR #35441: Size comparison from 9b58d4c to dee4d90

Full report (43 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
platform target config section 9b58d4c dee4d90 change % change
bl602 lighting-app bl602 FLASH 1279600 1279600 0 0.0
RAM 95904 95904 0 0.0
bl602+mfd FLASH 1293710 1293710 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1318564 1318564 0 0.0
RAM 104328 104328 0 0.0
bl702 lighting-app bl702 FLASH 944934 944934 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 947334 947334 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1040246 1040246 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 648006 648006 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 895420 895420 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 961594 961594 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 964216 964216 0 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678265 678265 0 0.0
RAM 78556 78556 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698117 698117 0 0.0
RAM 81188 81188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698117 698117 0 0.0
RAM 81188 81188 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655053 655053 0 0.0
RAM 73624 73624 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614601 614601 0 0.0
RAM 71524 71524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634237 634237 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634237 634237 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 632625 632625 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652341 652341 0 0.0
RAM 77092 77092 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652341 652341 0 0.0
RAM 77092 77092 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 606917 606917 0 0.0
RAM 68580 68580 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 626769 626769 0 0.0
RAM 71212 71212 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 626769 626769 0 0.0
RAM 71212 71212 0 0.0
esp32 all-clusters-app c3devkit DRAM 94128 94128 0 0.0
FLASH 1538110 1538110 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115064 115064 0 0.0
FLASH 1548558 1548558 0 0.0
IRAM 117039 117039 0 0.0
linux chip-tool-ipv6only arm64 unknown 20344 20344 0 0.0
FLASH 11323156 11323156 0 0.0
RAM 608376 608376 0 0.0
thermostat-no-ble arm64 unknown 9296 9296 0 0.0
FLASH 4328868 4328868 0 0.0
RAM 241944 241944 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914064 914064 0 0.0
RAM 142252 142252 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885732 885732 0 0.0
RAM 140391 140391 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845456 845456 0 0.0
RAM 141070 141070 0 0.0
nxp contact k32w0+release FLASH 579500 579500 0 0.0
RAM 70676 70676 0 0.0
k32w1+release FLASH 593328 593328 0 0.0
RAM 62712 62712 0 0.0
light k32w0+release FLASH 615128 615128 0 0.0
RAM 70140 70140 0 0.0
k32w1+release FLASH 676952 676952 0 0.0
RAM 47848 47848 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1645964 1645964 0 0.0
RAM 210944 210944 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1549596 1549596 0 0.0
RAM 207656 207656 0 0.0
light cy8ckit_062s2_43012 FLASH 1468388 1468388 0 0.0
RAM 200752 200752 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463660 1463660 0 0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 657804 657804 0 0.0
RAM 105192 105192 0 0.0
lock-app qpg6105+debug FLASH 615960 615960 0 0.0
RAM 99660 99660 0 0.0
stm32 light STM32WB5MM-DK FLASH 481608 481608 0 0.0
RAM 144740 144740 0 0.0
tizen all-clusters-app arm unknown 4840 4840 0 0.0
FLASH 1722416 1722416 0 0.0
RAM 89548 89548 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17499570 17499570 0 0.0
RAM 7596248 7596248 0 0.0

@woody-apple woody-apple merged commit f89d5b9 into project-chip:master Sep 6, 2024
64 of 67 checks passed
@woody-apple woody-apple deleted the fixing-xpc branch September 6, 2024 06:18
andy31415 pushed a commit to andy31415/connectedhomeip that referenced this pull request Sep 6, 2024
@andreilitvin
Revert "Updating XPC interfaces to pass along context, and fixing som…
6a5689c 
…e retries (project-chip#35441)"

This reverts commit f89d5b9.
@andy31415 andy31415 mentioned this pull request Sep 6, 2024
Merged
andy31415 added a commit that referenced this pull request Sep 6, 2024
@andy31415 @andreilitvin
Revert "Updating XPC interfaces to pass along context, and fixing som…
96e687b 
…e retries (#35441)" (#35457)

This reverts commit f89d5b9.

Co-authored-by: Andrei Litvin <[email protected]>
austina-csa pushed a commit to austina-csa/connectedhomeip that referenced this pull request Sep 20, 2024
@andy31415 @andreilitvin @austina-csa
Revert "Updating XPC interfaces to pass along context, and fixing som…
d00d519 
…e retries (project-chip#35441)" (project-chip#35457)

This reverts commit f89d5b9.

Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
darwin fast track
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woody-apple @restyled-commits