Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch: Fix cluster revision in XML to match new spec #35440

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Switch: Fix cluster revision in XML to match new spec #35440

merged 2 commits into from
Sep 6, 2024

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Sep 5, 2024 •
edited
Loading

Fixes #34247

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

PR #35440: Size comparison from 7219ad2 to 456fcce

Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 7219ad2 456fcce change % change
bl602 lighting-app bl602 FLASH 1279596 1279596 0 0.0
RAM 95904 95904 0 0.0
bl602+mfd FLASH 1293706 1293706 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1318560 1318560 0 0.0
RAM 104328 104328 0 0.0
bl702 lighting-app bl702 FLASH 944934 944934 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 947334 947334 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1040246 1040246 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 648006 648006 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 895420 895420 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 961594 961594 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 964216 964216 0 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678265 678265 0 0.0
RAM 78556 78556 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698117 698117 0 0.0
RAM 81188 81188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698117 698117 0 0.0
RAM 81188 81188 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655053 655053 0 0.0
RAM 73624 73624 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614601 614601 0 0.0
RAM 71524 71524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634237 634237 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634237 634237 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 632625 632625 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652341 652341 0 0.0
RAM 77092 77092 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652341 652341 0 0.0
RAM 77092 77092 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 606917 606917 0 0.0
RAM 68580 68580 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 626769 626769 0 0.0
RAM 71212 71212 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 626769 626769 0 0.0
RAM 71212 71212 0 0.0
efr32 lighting-app BRD4187C FLASH 933684 933684 0 0.0
RAM 135120 135120 0 0.0
lock-app BRD4338a FLASH 740772 740772 0 0.0
RAM 197184 197184 0 0.0
window-app BRD4187C FLASH 1017448 1017440 -8 -0.0
RAM 127060 127060 0 0.0
esp32 all-clusters-app c3devkit DRAM 94128 94128 0 0.0
FLASH 1538110 1538110 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115064 115064 0 0.0
FLASH 1548558 1548558 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2764521 2764521 0 0.0
RAM 128536 128536 0 0.0
all-clusters-app debug unknown 5408 5408 0 0.0
FLASH 6075316 6075316 0 0.0
RAM 510568 510568 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5399428 5399428 0 0.0
RAM 240376 240376 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4733262 4733262 0 0.0
RAM 217368 217368 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 1264925 1264925 0 0.0
RAM 558298 558298 0 0.0
chip-tool-ipv6only arm64 unknown 20344 20344 0 0.0
FLASH 11321460 11321460 0 0.0
RAM 608328 608328 0 0.0
fabric-admin debug unknown 5664 5664 0 0.0
FLASH 10956673 10956673 0 0.0
RAM 557290 557290 0 0.0
fabric-bridge-app debug unknown 4520 4520 0 0.0
FLASH 4556096 4556096 0 0.0
RAM 204016 204016 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5680817 5680817 0 0.0
RAM 228184 228184 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4787898 4787898 0 0.0
RAM 203768 203768 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4427468 4427468 0 0.0
RAM 197752 197752 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4566022 4566022 0 0.0
RAM 202288 202288 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3101757 3101757 0 0.0
RAM 159200 159200 0 0.0
thermostat-no-ble arm64 unknown 9296 9296 0 0.0
FLASH 4327140 4327140 0 0.0
RAM 241896 241896 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6014421 6014421 0 0.0
RAM 583240 583240 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10855533 10855533 0 0.0
RAM 645768 645768 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913816 913816 0 0.0
RAM 142244 142244 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885552 885552 0 0.0
RAM 140383 140383 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845204 845204 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 579500 579500 0 0.0
RAM 70676 70676 0 0.0
k32w1+release FLASH 593328 593328 0 0.0
RAM 62712 62712 0 0.0
light k32w0+release FLASH 615128 615128 0 0.0
RAM 70140 70140 0 0.0
k32w1+release FLASH 676952 676952 0 0.0
RAM 47848 47848 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1645932 1645932 0 0.0
RAM 210944 210944 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1549580 1549580 0 0.0
RAM 207656 207656 0 0.0
light cy8ckit_062s2_43012 FLASH 1468356 1468356 0 0.0
RAM 200752 200752 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463644 1463644 0 0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 657804 657804 0 0.0
RAM 105192 105192 0 0.0
lock-app qpg6105+debug FLASH 615960 615960 0 0.0
RAM 99660 99660 0 0.0
stm32 light STM32WB5MM-DK FLASH 481608 481608 0 0.0
RAM 144740 144740 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620506 620506 0 0.0
RAM 50932 50932 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 685998 685998 0 0.0
RAM 149576 149576 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 778438 778438 0 0.0
RAM 110736 110736 0 0.0
bridge-app tlsr9258a FLASH 679498 679498 0 0.0
RAM 91588 91588 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622098 622098 0 0.0
RAM 50972 50972 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708108 708108 0 0.0
RAM 74312 74312 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 624298 624298 0 0.0
RAM 145556 145556 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 810430 810430 0 0.0
RAM 99480 99480 0 0.0
lock-app-dfu tlsr9528a FLASH 655080 655080 0 0.0
RAM 67008 67008 0 0.0
ota-requestor-app tlsr9258a FLASH 697364 697364 0 0.0
RAM 91272 91272 0 0.0
pump-app-usb tlsr9518adk80d FLASH 631806 631806 0 0.0
RAM 55752 55752 0 0.0
pump-controller-app tlsr9518adk80d FLASH 609054 609054 0 0.0
RAM 52996 52996 0 0.0
shell tlsr9518adk80d FLASH 466890 466890 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628884 628884 0 0.0
RAM 52692 52692 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653036 653036 0 0.0
RAM 56632 56632 0 0.0
thermostat tlsr9518adk80d FLASH 635786 635786 0 0.0
RAM 53400 53400 0 0.0
window-covering tlsr9118bdk40d FLASH 523040 523040 0 0.0
RAM 98532 98532 0 0.0
tizen all-clusters-app arm unknown 4840 4840 0 0.0
FLASH 1721372 1721372 0 0.0
RAM 89524 89524 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17495182 17495182 0 0.0
RAM 7593956 7593956 0 0.0

@mergify mergify bot merged commit d5f0606 into project-chip:master Sep 6, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneJosefsen ReneJosefsen ReneJosefsen approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

Assignees
No one assigned
Labels
app controller examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Switch Cluster] Cluster Revision value has to be updated as per Spec in Switch Cluster XML
4 participants
@cecille @tcarmelveilleux @bzbarsky-apple @ReneJosefsen