-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Wi-fi: Cleanup wfx host events header file #35430
[Silabs] Wi-fi: Cleanup wfx host events header file #35430
Conversation
Review changes with SemanticDiff. |
beeca96
to
62a6159
Compare
PR #35430: Size comparison from edf1f65 to c2ae4c3 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35430: Size comparison from 16b1e5b to 607c369 Full report (79 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35430: Size comparison from 22db90a to 4da6f6b Full report (79 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35430: Size comparison from 22db90a to cc1963c Full report (79 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35430: Size comparison from 1dacd5d to a77f95a Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok, but it most a bunch of conditional includes and defines and what not.
You pr description doesn't clearly state what was built and tested.
Did you build different apps and different configurations? did you test them at run time?
|
PR #35430: Size comparison from e6a6425 to a002962 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35430: Size comparison from 12f04dc to ef01566 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
* Added the common wfx_host_events header for efr and 917 SoC platforms * Cleanup task priority macros * Added macros only for RS9116 * Resolved review comments * Cleaned up wf200 macros * Cleaned up 917 SoC and NCP macros
Duplicated
wfx_host_events.h
files removed and added common header for EFR and SiWx917