-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDM-10.2: Handle MACL feature #35404
Merged
mergify
merged 2 commits into
project-chip:master
from
cecille:IDM_10_2_fix_for_MACL_2_electric_boogaloo
Sep 4, 2024
Merged
IDM-10.2: Handle MACL feature #35404
mergify
merged 2 commits into
project-chip:master
from
cecille:IDM_10_2_fix_for_MACL_2_electric_boogaloo
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct-chip#35111) This reverts commit 796394f.
Review changes with SemanticDiff. Analyzed 3 of 4 files.
|
github-actions
bot
added
github
workflows
tests
matter-1.4-te2-script-change
Script changes before end of Matter 1.4 TE2
labels
Sep 4, 2024
PR #35404: Size comparison from 6144736 to acb3eb8 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
changed the title
Reapply "TC-IDM-10.2: Add check for MACL (#35086)" (#35111)
IDM-10.2: Handle MACL feature
Sep 4, 2024
chrisdecenzo
reviewed
Sep 4, 2024
chrisdecenzo
reviewed
Sep 4, 2024
PR #35404: Size comparison from 6144736 to 7f21c79 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve and
harimau-qirex
September 4, 2024 16:09
pullapprove
bot
requested review from
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
September 4, 2024 16:09
robszewczyk
approved these changes
Sep 4, 2024
chrisdecenzo
approved these changes
Sep 4, 2024
tcarmelveilleux
approved these changes
Sep 4, 2024
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
* Reapply "TC-IDM-10.2: Add check for MACL (project-chip#35086)" (project-chip#35111) This reverts commit 796394f. * Change function name to more generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
github
matter-1.4-te2-script-change
Script changes before end of Matter 1.4 TE2
review - approved
tests
workflows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MACL feature is desc in the spec, so needs special handling for the conformance test.
This reverts commit 796394f.
Reapply "TC-IDM-10.2: Add check for MACL (#35086)" (#35111)