TC_EEVSE_2.2 through 2.5 python script has to be updated as per the test plan changes #35399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in diagnostics mode which should return failure).
|
Review changes with SemanticDiff. Analyzed 4 of 4 files. Overall, the semantic diff is 71% smaller than the GitHub diff.
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
jamesharrow
changed the base branch from
34100-tc-eevse-2224-25-python-script-has-to-be-updated-as-per-the-test-plan-changes
to
master
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex and
harsha-rajendran
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
jamesharrow
changed the title
arkq
approved these changes
Sep 4, 2024
|
PR #35399: Size comparison from 1e1fe1e to 36af6e4 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Sep 4, 2024
jamesharrow
deleted the
34100-tc-eevse-2224-25-python-script-has-to-be-updated-as-per-the-test-plan-changes
branch
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
…est plan changes (project-chip#35399) * Updated 2.2 test steps - autogen'd from test plan. No functional changes. * Update TC EEVSE 2.3 with autogen'd test steps. No functional code change. * Updated TC_EEVSE_2.4 test steps - no functional code changes. * TC_EEVSE_2.5 - updated test steps - no functional changes. * TC_EEVSE_2.5 added new step 8 (try to send Enable Charge Command when in diagnostics mode which should return failure).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some late notice change to align the test script words with test plan.
Mostly 'TestStep' changes to align with test plan (see PR: https://github.com/CHIP-Specifications/chip-test-plans/pull/4071)
TC_EEVSE_2.5 has new step 8 which tries to send a EnableCharging when in Diagnostics test mode, so this vaildates it gets a Failure in response.
Note that most of the test step changes are auto-gen'd from the test plan (with macro expansion) - so should align.