Make DM provider and ember encode errors the same #35338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nit testing. Implement a separate flag to control if we crash on errors for IM/DM checks or not.
Co-authored-by: Boris Zbarsky <[email protected]>
|
Review changes with SemanticDiff. Analyzed 10 of 41 files. Overall, the semantic diff is 10% smaller than the GitHub diff. File Information
|
github-actions
bot
added
examples
scripts
darwin
controller
app
github
workflows
tests
matter-1.4-te2-script-change
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan and
bzbarsky-apple
|
PR #35338: Size comparison from ce3b4d9 to ba70abf Full report (10 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #35338: Size comparison from ce3b4d9 to cc4e9e0 Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #35338: Size comparison from ce3b4d9 to 27cf823 Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35338: Size comparison from ce3b4d9 to 54734d3 Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35338: Size comparison from 44f8837 to 9805dde Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Sep 4, 2024
tehampson
reviewed
Sep 4, 2024
tehampson
approved these changes
Sep 4, 2024
bzbarsky-apple
approved these changes
Sep 4, 2024
|
PR #35338: Size comparison from 44f8837 to 8eb3645 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35338: Size comparison from 44f8837 to 5c0af60 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
* The flag of CONFIG_BUILD_FOR_HOST_UNIT_TEST is not actually tied to unit testing. Implement a separate flag to control if we crash on errors for IM/DM checks or not. * Update src/app/common_flags.gni Co-authored-by: Boris Zbarsky <[email protected]> * make the flag name singular * Add unit test cluster members * Modified zap and made these attributes optional * Zap regen * Attributes MUST be up to 0x4FFF so needed to switch codes * Update ids enabling * Move around things and add unit test * Update to run unit tests with enforced DM checking * Comment describing the updated options * Fix unit test * Restyle * Kotlin format since it seems different eforcement is going on here * Update src/app/zap-templates/zcl/data-model/chip/test-cluster.xml Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/all-clusters-app/linux/main-common.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Remove redundant using * Simplify/shorten code * Move base to 0x3000 for the new attributes for test cluster testing * Restyle * Fix python unit test * Fix all clusters app * Fix unused import in python * Zap regen * Fix cirque * Fix hardcoded paths in TestTimeSyncTrustedtimeSourceRunner.py * Typo fix * Remove extra spacing * Update text * Fix app path --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes