[nrfconnect] Fix the case when the Wi-Fi info cannot be retrieved #35275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
pullapprove
bot
added
review - pending
platform
nrf connect
and removed
platform
nrf connect
labels
Don't pass uninitialized WiFiInfo object to the OnNetworkingStatusChange() callback in case the GetWiFiInfo() fails. Use GetWantedNetwork() return value as a fallback. Signed-off-by: Marcin Kajor <[email protected]>
Damian-Nordic
approved these changes
Aug 29, 2024
markaj-nordic
force-pushed
the
nrf_fix_wifi_clbk_invocation
branch
from
f4a7965 to
a346cfb
Compare
|
PR #35275: Size comparison from 203f03a to a346cfb Full report (88 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Aug 29, 2024
kiel-apple
approved these changes
Aug 30, 2024
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
…oject-chip#35275) Don't pass uninitialized WiFiInfo object to the OnNetworkingStatusChange() callback in case the GetWiFiInfo() fails. Use GetWantedNetwork() return value as a fallback. Signed-off-by: Marcin Kajor <[email protected]>
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Nov 5, 2024
…e retrieved (project-chip#35275) Don't pass uninitialized WiFiInfo object to the OnNetworkingStatusChange() callback in case the GetWiFiInfo() fails. Use GetWantedNetwork() return value as a fallback. Signed-off-by: Marcin Kajor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't pass uninitialized WiFiInfo object to the
OnNetworkingStatusChange() callback in case the GetWiFiInfo() fails.
Use GetWantedNetwork() return value as a fallback.