Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fixes to match the test scripts to the test plan #35265

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Make fixes to match the test scripts to the test plan #35265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6376082
Make fixes to match the test scripts to the test plan
nivi-apple Aug 28, 2024
4e561ff
Restyled by prettier-yaml
restyled-commits Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/app/tests/suites/certification/PICS.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6494,6 +6494,13 @@ PICS:
- label: "Does the device implement the Schedules attribute?"
id: TSTAT.S.A0051

- label: "Does the device implement the Schedules attribute?"
id: TSTAT.S.A0051

- label:
"Does the device implement the SetpointHoldExpiryTimestamp attribute?"
id: TSTAT.S.A0052

#
# server / commandsReceived
#
Expand Down
33 changes: 6 additions & 27 deletions src/app/tests/suites/certification/Test_TC_TSTAT_1_1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,17 +606,7 @@ tests:
contains: [1, 2, 3]

- label:
"Step 6c: TH reads the optional (GetRelayStatusLog) command in
AcceptedCommandList"
PICS: TSTAT.S.C04.Rsp
command: "readAttribute"
attribute: "AcceptedCommandList"
response:
constraints:
type: list
contains: [4]
- label:
"Step 6d: TH reads Feature dependent(TSTAT.S.F08(PRES)) commands in
"Step 6c: TH reads Feature dependent(TSTAT.S.F08(PRES)) commands in
AcceptedCommandList"
PICS: TSTAT.S.F08
command: "readAttribute"
Expand All @@ -627,18 +617,7 @@ tests:
contains: [6, 254]

- label:
"Step 7a: TH reads Feature dependent(TSTAT.S.F08(PRES)) commands in
the GeneratedCommandList attribute."
PICS: TSTAT.S.Cfe.Rsp
command: "readAttribute"
attribute: "GeneratedCommandList"
response:
value: [0xFD] # AtomicResponse
constraints:
type: list

- label:
"Step 7b: TH reads Feature dependent(TSTAT.S.F03(SCH)) commands in
"Step 7a: TH reads Feature dependent(TSTAT.S.F03(SCH)) commands in
GeneratedCommandList"
PICS: TSTAT.S.F03
command: "readAttribute"
Expand All @@ -649,12 +628,12 @@ tests:
contains: [0]

- label:
"Step 7c: TH reads optional command (GetRelayStatusLogResponse) in
GeneratedCommandList"
PICS: TSTAT.S.C04.Rsp
"Step 7b: TH reads Feature dependent(TSTAT.S.F08(PRES)) commands in
the GeneratedCommandList attribute."
PICS: TSTAT.S.F08 & TSTAT.S.Cfe.Rsp
command: "readAttribute"
attribute: "GeneratedCommandList"
response:
value: [0xFD] # AtomicResponse
constraints:
type: list
contains: [1]
1 change: 1 addition & 0 deletions src/app/tests/suites/certification/ci-pics-values
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1989,6 +1989,7 @@ TSTAT.S.A004a=1
TSTAT.S.A004e=1
TSTAT.S.A0050=1
TSTAT.S.A0051=0
TSTAT.S.A0052=0

TSTAT.S.M.MinSetpointDeadBandWritable=1
TSTAT.S.M.HVACSystemTypeConfigurationWritable=0
Expand Down
Loading