M-ACL: switch from UnsupportedAccess to AccessRestricted #35263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct-chip#35181) Signed-off-by: Axel Le Bourhis <[email protected]>
|
Review changes with SemanticDiff. Analyzed 3 of 18 files.
|
github-actions
bot
added
platform
zephyr
lib
controller
app
tests
core
protocols
matter-1.4-te2-script-change
github-actions
bot
added
the
documentation
|
PR #35263: Size comparison from 6b5a2ce to 7c13805 Full report (88 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35263: Size comparison from 18a1863 to d9be729 Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #35263: Size comparison from 89f740d to 6b4f184 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35263: Size comparison from 63da540 to 1e1a70c Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
src/app/codegen-data-model-provider/CodegenDataModelProvider_Write.cpp
Outdated
Show resolved
Hide resolved
|
PR #35263: Size comparison from 9bbf5b9 to 7ca6d77 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
tcarmelveilleux
approved these changes
Aug 29, 2024
hawk248
approved these changes
Aug 29, 2024
|
PR #35263: Size comparison from 9bbf5b9 to 01b722c Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Aug 29, 2024
chrisdecenzo
approved these changes
Aug 29, 2024
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
…p#35263) * Implement new AccessRestricted error code * [NXP][Zephyr] Provide AP band in connection request parameters (project-chip#35181) Signed-off-by: Axel Le Bourhis <[email protected]> * added missed ERROR_CODES.md update * fixed build issue * restyled * fix return type in CodegenDataModelProvider_Write.cpp * fix review comments --------- Signed-off-by: Axel Le Bourhis <[email protected]> Co-authored-by: Axel Le Bourhis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AccessRestrictionProvider to return CHIP_ERROR_ACCESS_RESTRICTED_BY_ARL which is mapped to IM status AccessRestricted in the spec.
Fixes #35177