-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DRLK-2.5 and DRLK-2.9 python script #35201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. |
github-actions
bot
added
app
tests
matter-1.4-te2-script-change
Script changes before end of Matter 1.4 TE2
labels
Aug 26, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo and
chshu
August 26, 2024 17:22
PR #35201: Size comparison from acba7f8 to 489ea54 Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
PR #35201: Size comparison from acba7f8 to 971daa9 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35201: Size comparison from acba7f8 to 89eb946 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jrhees-cae
suggested changes
Sep 16, 2024
1.correted test step description for step 4,5,6 and 9 2.Corrected steps 5,6 and 9
1. Corrected test step description 2. Corrected PICS 3. Validated arrtibutes read based on respective range 4. modified get_user function to check for given credentialsirespective to the order of credentials listed
jrhees-cae
suggested changes
Sep 17, 2024
…t matches with length of response credential list
jrhees-cae
suggested changes
Sep 17, 2024
jrhees-cae
approved these changes
Sep 18, 2024
andy31415
approved these changes
Sep 30, 2024
3 tasks
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* added drlkcluster variable * Delete src/python_testing/TC_DRLK_2_9.py * added DRLK_2.5 python script * Added Script DRLK_2.9 * removed DRLK_2_5 yaml file * removed DRLK_2.9.yaml file * updated DLOG_2_1.yaml * removed redefined command clear user * removed unsed var * removed unused var * Updated TC_DRLK_2_4.yaml script as per test plan * Updated the TC to include PIN, Aliro combination and do Modify credential * Restyled by autopep8 * updated PICS * Appended steps to check modify of both PIN and Aliro credentiaType is as expected * Updated DRLK-2.5 test case as per PR comment 1.correted test step description for step 4,5,6 and 9 2.Corrected steps 5,6 and 9 * Updated DRLK-2.9 1. Corrected test step description 2. Corrected PICS 3. Validated arrtibutes read based on respective range 4. modified get_user function to check for given credentialsirespective to the order of credentials listed * Added nextcredentialIndex check in get_credential_status function * fixed code-lints error * Added generate_max_pincode_len for generating valid pin code of Max pincode length * Restyled by isort * added a check in get_user funtion that length of given Credential list matches with length of response credential list * PR review -Init the pin and rid variables * fixed lint error --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
fast track
matter-1.4-te2-script-change
Script changes before end of Matter 1.4 TE2
review - pending
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed existing DRLK_2_5, DRLK_2_9 yaml files as the test plan requires looping - moved to python
updated DLOG_2_1.yaml
updated DRLK_2.4 yaml script as per test plan update
fixes https://github.com/CHIP-Specifications/chip-test-plans/issues/4515