Remove handling of the unitTestInject* bits in base MTRDevice. #35180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
pullapprove
bot
requested review from
rcasallas-silabs,
ReneJosefsen,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #35180: Size comparison from 9520bef to a188407 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
force-pushed
the
mtrdevice-unit-test-inject
branch
from
a188407 to
74bfb0d
Compare
These injections need to be handled by subclasses, because the subclasses do very different report processing and have different mechanisms for getting reports. Once these implementations are removed, the following become unreachable and can be removed: * _handleEventReport * _handleReportBegin * _handleAttributeReport * _handleReportEnd Once those are removed, the following become unreachable or unused and can be removed: * _receivingReport (always false) * _receivingPrimingReport (always false, because _receivingReport is always false) * _changeState * _callDelegateDeviceCachePrimed * unreportedEvents * _getAttributesToReportWithReportedValues Once those are removed, the following become unreachable or unused and can be removed: * _setCachedAttributeValue * _noteDataVersion * _deviceConfigurationChanged * estimatedStartTimeFromGeneralDiagnosticsUpTime * _attributeAffectsDeviceConfiguration * _pruneStoredDataForPath Once those are removed, the following become unreachable or unused and can be removed: * _pruneEndpointsIn * _pruneClustersIn * _pruneAttributesIn * _attributePathAffectsDescriptionData * _addInformationalAttributesToCurrentMetricScope * AttributeHasChangesOmittedQuality Once those are removed, the following become unreachable or unused and can be removed: * _removeAttributes * _removeClusters Once those are removed, the following become unreachable or unused and can be removed: * _removeCachedAttribute
bzbarsky-apple
force-pushed
the
mtrdevice-unit-test-inject
branch
from
74bfb0d to
3c2f762
Compare
|
PR #35180: Size comparison from a93f4b6 to 3c2f762 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jtung-apple
approved these changes
Aug 26, 2024
|
Fast-tracking platform-specific fix with platform owner review. |
PeterC1965
pushed a commit
to PeterC1965/connectedhomeip
that referenced
this pull request
Aug 28, 2024
…ct-chip#35180) These injections need to be handled by subclasses, because the subclasses do very different report processing and have different mechanisms for getting reports. Once these implementations are removed, the following become unreachable and can be removed: * _handleEventReport * _handleReportBegin * _handleAttributeReport * _handleReportEnd Once those are removed, the following become unreachable or unused and can be removed: * _receivingReport (always false) * _receivingPrimingReport (always false, because _receivingReport is always false) * _changeState * _callDelegateDeviceCachePrimed * unreportedEvents * _getAttributesToReportWithReportedValues Once those are removed, the following become unreachable or unused and can be removed: * _setCachedAttributeValue * _noteDataVersion * _deviceConfigurationChanged * estimatedStartTimeFromGeneralDiagnosticsUpTime * _attributeAffectsDeviceConfiguration * _pruneStoredDataForPath Once those are removed, the following become unreachable or unused and can be removed: * _pruneEndpointsIn * _pruneClustersIn * _pruneAttributesIn * _attributePathAffectsDescriptionData * _addInformationalAttributesToCurrentMetricScope * AttributeHasChangesOmittedQuality Once those are removed, the following become unreachable or unused and can be removed: * _removeAttributes * _removeClusters Once those are removed, the following become unreachable or unused and can be removed: * _removeCachedAttribute
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
…ct-chip#35180) These injections need to be handled by subclasses, because the subclasses do very different report processing and have different mechanisms for getting reports. Once these implementations are removed, the following become unreachable and can be removed: * _handleEventReport * _handleReportBegin * _handleAttributeReport * _handleReportEnd Once those are removed, the following become unreachable or unused and can be removed: * _receivingReport (always false) * _receivingPrimingReport (always false, because _receivingReport is always false) * _changeState * _callDelegateDeviceCachePrimed * unreportedEvents * _getAttributesToReportWithReportedValues Once those are removed, the following become unreachable or unused and can be removed: * _setCachedAttributeValue * _noteDataVersion * _deviceConfigurationChanged * estimatedStartTimeFromGeneralDiagnosticsUpTime * _attributeAffectsDeviceConfiguration * _pruneStoredDataForPath Once those are removed, the following become unreachable or unused and can be removed: * _pruneEndpointsIn * _pruneClustersIn * _pruneAttributesIn * _attributePathAffectsDescriptionData * _addInformationalAttributesToCurrentMetricScope * AttributeHasChangesOmittedQuality Once those are removed, the following become unreachable or unused and can be removed: * _removeAttributes * _removeClusters Once those are removed, the following become unreachable or unused and can be removed: * _removeCachedAttribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These injections need to be handled by subclasses, because the subclasses do very different report processing and have different mechanisms for getting reports.
Once these implementations are removed, the following become unreachable and can be removed:
Once those are removed, the following become unreachable or unused and can be removed:
Once those are removed, the following become unreachable or unused and can be
removed:
Once those are removed, the following become unreachable or unused and can be
removed:
Once those are removed, the following become unreachable or unused and can be
removed:
Once those are removed, the following become unreachable or unused and can be
removed: