Code

Address comments from reviews#34884

Code

Merged

mergify[bot] merged 77 commits intoproject-chip:masterproject-chip/connectedhomeip:masterfrom dysonltd:address_comments_from_reviewsdysonltd/connectedhomeip:address_comments_from_reviewsCopy head branch name to clipboardAug 9, 2024

+22-27

Commits

Commits on Jul 31, 2024

• Updated the golabl data type's XMLs, removing the cluster entries.

  hicklin

  committed
  e4087bd

• Zap generated after XML update.

  hicklin

  committed
  7342db3

• Fixed namespaces used of global structs.

  hicklin

  committed
  63edf2e

• Restyled by clang-format

  

  restyled-commits

  authored and

  hicklin

  committed
  1cab752

Commits on Aug 1, 2024

• Renamed LocationInfoStruct to AreaInfoStruct.

  hicklin

  committed
  72de6c5

• Zap generated after XML update.

  hicklin

  committed
  f2add10

• Renamed LocationStruct to AreaStruct and its LocationID and LocationDesc fields.

  hicklin

  committed
  c6134a6

• Zap generated after XML update.

  hicklin

  committed
  af8b02c

• Updated SDK and example code to match the new naming.

  hicklin

  committed
  a20d803

• Updated the ProgressStruct's LocationID name to AreaID.

  hicklin

  committed
  8bb0d34

• Zap generated after XML update.

  hicklin

  committed
  5bd0285

• Updated the SDK code following name changes.

  hicklin

  committed
  5dc5eb0

• Updated the SelectLocationsStatus and SkipLocationStatus enum names and some of their enums.

  hicklin

  committed
  5429771

• Zap generated after XML update.

  hicklin

  committed
  04e87b6

• Updated the SelectLocationsStatus and SkipCurrentLocationStatus names and their enum names.

  hicklin

  committed
  91f4446

• Updated the names of the SupportedLocations, SelectedLocations and CurrentLocation attributes.

  hicklin

  committed
  31a3c1a

• Zap generated after XML update.

  hicklin

  committed
  f7d6a54

• Updated the changed names in the SDK.

  hicklin

  committed
  4c128e6

• Updated the service area command names in XML.

  hicklin

  committed
  088f01d

• Zap generated after XML update.

  hicklin

  committed
  a6b8036

• Updated the service area command names in the SDK.

  hicklin

  committed
  69eb53f

• Updated the rvc-example zap file.

  hicklin

  committed
  c6c3659

• Refactored LocationStructureWrapper to AreaStructureWrapper.

  hicklin

  committed
  d378b4e

• Merge branch 'master' into update_names

  hicklin

  authored
  75a3369

• Restyled by clang-format

  

  restyled-commits

  authored and

  hicklin

  committed
  86c38ed

• Regenerated zap files due to changes upsteram.

  hicklin

  committed
  a611a5b

Commits on Aug 2, 2024

• Merge branch 'master' into update_names

  hicklin

  authored
  56d0184

• Removed unused generated file.

  hicklin

  committed
  b3abfbd

• Updated the Service Area XML marking previously nullabel attributes as not-nullable.

  hicklin

  committed
  e82a96e

• Zap generated after XML update.

  hicklin

  committed
  f48fb79

• Updated the attribute encoding and some server logic following the romoval of the nullable quality for some attributes.

  hicklin

  committed
  499b42d

• Explicitly set the Service Area version.

  hicklin

  committed
  1aa272e

• Zap generated after XML update.

  hicklin

  committed
  3881db0

• Updated the service area features in the XML to match the current spec.

  hicklin

  committed
  9a9b3bc

• Zap generated after XML update.

  hicklin

  committed
  d57ec78

• Updated the SupportedArea validation logic as if the MAPS feature is not supported, the Delegate may choose not to implement map related methods.

  hicklin

  committed
  15376cb

• Change the type of the MapID to uint32 to match the spec.

  hicklin

  committed
  43dd764

• Added the SkippedArea arg to the SkipArea command.

  hicklin

  committed
  ad374f1

• Zap generated after XML update.

  hicklin

  committed
  5979878

• Updated the Service Area server code to handle the new SkippedArea command arg.

  hicklin

  committed
  5b079da

• Updated the service area XML to match the current spec. This includes the addition of the LandmarkInfoStruct and updates of AreaInfoStruct, SelectAreasStatus.

  hicklin

  committed
  e8dd79c

• Zap generated after XML update.

  hicklin

  committed
  1eb0f17

• Updated SDK server code and rvc-example after changes to the XML.

  hicklin

  committed
  bf8d264

• Restyled by whitespace

  

  restyled-commits

  authored and

  hicklin

  committed
  54cbcc2

• added vector include.

  hicklin

  committed
  9548b69

Commits on Aug 5, 2024

• Merge branch 'master' into update_names

  hicklin

  committed
  afb1084

• spacing changes form zap regen.

  hicklin

  committed
  ba24897

• Fixed minor mistake during merge.

  hicklin

  committed
  4f61bf3

• Merge branch 'update_names' into remove_nullable_qualities

  hicklin

  committed
  30b4118

• Merge branch 'remove_nullable_qualities' into update_service_area_xml_from_07

  hicklin

  committed
  2325e2a

• Restyled by clang-format

  

  restyled-commits

  authored and

  hicklin

  committed
  21663d9

• Merge branch 'master' into remove_nullable_qualities. Fixed conflicts. Regenerated code.

  hicklin

  committed
  cd43089

• Merge branch 'remove_nullable_qualities' into update_service_area_xml_from_07

  hicklin

  committed
  82396bc

• Applied suggestions from review.

  hicklin

  committed
  b730832

• Restyled by whitespace

  

  restyled-commits

  authored and

  hicklin

  committed
  b3140db

Commits on Aug 6, 2024

• Merge branch 'master' into update_service_area_xml_from_07

  hicklin

  committed
  c7f248c

• Updated the LondmarkInfoSturct PositionTag type.

  hicklin

  committed
  22db496

• Zap generated after XML update.

  hicklin

  committed
  23b1c6b

• Fixed SDK following update to the position type.

  hicklin

  committed
  ec07b0e

• Restyled by clang-format

  

  restyled-commits

  authored and

  hicklin

  committed
  95c68f7

• Updated the AeraStructWrapper to not contain methods with a large number of params. Updated some relate Instance and Delegate methods.

  hicklin

  committed
  6fafcf9

• Restyled by whitespace

  

  restyled-commits

  authored and

  hicklin

  committed
  0a5ec9f

• Restyled by clang-format

  

  restyled-commits

  authored and

  hicklin

  committed
  6f9efb1

Commits on Aug 7, 2024

• Merge branch 'master' into update_service_area_xml_from_07. Fixed XML confilct and regenerated code.

  hicklin

  committed
  40c8298

• Missed a submudule update.

  hicklin

  committed
  0ec7d0b

• Merge branch 'update_service_area_xml_from_07' into improve_AreaStructWrapper

  hicklin

  committed
  ca10c9a

• Made the setters reture a ref to the sturct to allow chaining.

  hicklin

  committed
  f3df11c

• simplified the = oporator and add the == operator.

  hicklin

  committed
  ed743e4

• Restyled by clang-format

  

  restyled-commits

  authored and

  hicklin

  committed
  931557e

Commits on Aug 8, 2024

• Merge branch 'master' into improve_AreaStructWrapper

  Show description for 10c7abb
  hicklin

  committed
  10c7abb

• minor change to get restyler going.

  hicklin

  committed
  ccdc1e5

• Restyled by clang-format

  

  restyled-commits

  authored and

  hicklin

  committed
  35f5908

• Fixed status text referance issue.

  hicklin

  committed
  258e249

• Fixed issue casued by a change in the way that registrations are made.

  hicklin

  committed
  b7ae205

• Merge branch 'improve_AreaStructWrapper' into address_comments_from_reviews

  hicklin

  committed
  2ee994e

• Fixed styling and minor bug in IsValidSupportedArea.

  hicklin

  committed
  61e357b

Commits on Aug 9, 2024

• Merge branch 'master' into address_comments_from_reviews

  Show description for b0940e8
  hicklin

  committed
  b0940e8