Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking third party deps doesn't pass after someone fixes it #34872

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Checking third party deps doesn't pass after someone fixes it #34872

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
806e670
Fixing this to stop breaking PRs
woody-apple Aug 8, 2024
099826b
Qualifying as expression
woody-apple Aug 8, 2024
b00342b
Making this more readable now that it's an expression
woody-apple Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/third-party-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ name: Check for Unintentional Submodule Updates
on:
pull_request:
branches-ignore:
- 'dependabot/**'
- "dependabot/**"
paths:
- "third_party/**"
- ".gitmodules"
Expand All @@ -26,9 +26,14 @@ jobs:
check-submodule-update-label:
name: Check For Submodule Update Label
runs-on: ubuntu-latest
if: "!contains(github.event.pull_request.labels.*.name, 'changing-submodules-on-purpose')"
steps:
- name: Error Message
run: echo This pull request attempts to update submodules without the changing-submodules-on-purpose label. Please apply that label if the changes are intentional, or remove those changes.
- name: Fail Job
run: exit 1
- if: ${{ !contains(github.event.pull_request.labels.*.name, 'changing-submodules-on-purpose') }}
name: Fail
run: |
echo This pull request attempts to update submodules without the changing-submodules-on-purpose label. Please apply that label if the changes are intentional, or remove those changes.
exit 1
- if: ${{ contains(github.event.pull_request.labels.*.name, 'changing-submodules-on-purpose') }}
name: Success
run: |
echo PR looks good.
exit 0
Loading