-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TC-EEVSE_2_3 - Fixes #34576 Added missing step 22 #34779
Merged
mergify
merged 3 commits into
project-chip:master
from
jamesharrow:34576-14tc-eevse-23-python-script-has-to-be-updated-by-adding-step-22-as-per-the-test-plan
Aug 6, 2024
Merged
TC-EEVSE_2_3 - Fixes #34576 Added missing step 22 #34779
mergify
merged 3 commits into
project-chip:master
from
jamesharrow:34576-14tc-eevse-23-python-script-has-to-be-updated-by-adding-step-22-as-per-the-test-plan
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… plan, but missing in the test script.
Review changes with SemanticDiff. Analyzed 2 of 2 files.
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
Script changes before end of Matter 1.4 TE2
labels
Aug 5, 2024
…e-updated-by-adding-step-22-as-per-the-test-plan
…e-updated-by-adding-step-22-as-per-the-test-plan
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin and
jepenven-silabs
August 5, 2024 15:41
pullapprove
bot
requested review from
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 5, 2024 15:41
PR #34779: Size comparison from b9c192b to 3cfc853 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Aug 6, 2024
rbultman
approved these changes
Aug 6, 2024
lpbeliveau-silabs
approved these changes
Aug 6, 2024
jamesharrow
deleted the
34576-14tc-eevse-23-python-script-has-to-be-updated-by-adding-step-22-as-per-the-test-plan
branch
August 6, 2024 19:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34576
There was a slight missing 'cleanup' step '22' at the end of TC_EEVSE_2_3 that did not align to the test plan.
This resolves that problem.
Python script reference:
https://github.com/project-chip/connectedhomeip/blob/master/src/python_testing/TC_EEVSE_2_3.py
Test plan reference:
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/energy_EVSE.adoc#tc-eevse-2-3-optional-chargingpreferences-feature-functionality-with-dut_server