-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infineon] Provision to enable/disable NOC key-pair generation using HSM #34770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ankk-css
commented
Aug 5, 2024
- Added the flag ENABLE_TRUSTM_NOC_KEYGEN in the config.
- Updated the functions to support NOC keygen with and without Trust M MTR.
- Restyled changes
* Added the flag ENABLE_TRUSTM_NOC_KEYGEN in the config. * Updated the functions to support NOC keygen with and without trustm. * Restyled changes
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
August 5, 2024 03:20
PR #34770: Size comparison from bbef51a to 773f5bd Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
src/platform/Infineon/crypto/trustm/CHIPCryptoPALHsm_P256_trustm.cpp
Outdated
Show resolved
Hide resolved
src/platform/Infineon/crypto/trustm/CHIPCryptoPALHsm_P256_trustm.cpp
Outdated
Show resolved
Hide resolved
src/platform/Infineon/crypto/trustm/CHIPCryptoPALHsm_P256_trustm.cpp
Outdated
Show resolved
Hide resolved
PR #34770: Size comparison from 653a55f to cd0d970 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34770: Size comparison from 212d6ab to 434491f Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34770: Size comparison from 514b9eb to 8755436 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Aug 8, 2024
woody-apple
added
the
changing-submodules-on-purpose
Marker that this PR is changing submodules (and it is not a "commit all" typo/mistake)
label
Aug 8, 2024
PR #34770: Size comparison from 57ebcbc to 8755436 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Aug 8, 2024
PR #34770: Size comparison from 681f951 to cf2bd64 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ankk-css
added a commit
to ying-css/connectedhomeip
that referenced
this pull request
Aug 12, 2024
…HSM (project-chip#34770) * Provision to select NOC key-pair generation using Trust M MTR or fw. * Added the flag ENABLE_TRUSTM_NOC_KEYGEN in the config. * Updated the functions to support NOC keygen with and without trustm. * Restyled changes * Minor bug fixes.
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Aug 12, 2024
…HSM (project-chip#34770) * Provision to select NOC key-pair generation using Trust M MTR or fw. * Added the flag ENABLE_TRUSTM_NOC_KEYGEN in the config. * Updated the functions to support NOC keygen with and without trustm. * Restyled changes * Minor bug fixes.
ankk-css
added a commit
to ying-css/connectedhomeip
that referenced
this pull request
Aug 13, 2024
…HSM (project-chip#34770) * Provision to select NOC key-pair generation using Trust M MTR or fw. * Added the flag ENABLE_TRUSTM_NOC_KEYGEN in the config. * Updated the functions to support NOC keygen with and without trustm. * Restyled changes * Minor bug fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changing-submodules-on-purpose
Marker that this PR is changing submodules (and it is not a "commit all" typo/mistake)
fast track
platform
review - pending
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.