[android] Feat: retry GATT_ERROR 133 on device.connectGatt fail #34697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
j0tunn
force-pushed
the
fix/android.retry.gatt.err.133
branch
from
4f23b08 to
03bc07d
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34697: Size comparison from 5d280de to 03bc07d Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
joonhaengHeo
reviewed
Aug 5, 2024
|
I think the files below might need the same fixes. |
Probably the best solution is if chip-tool BluetoothManager will use whole connect pipeline. Not just some callbacks. But thats should be done in separate PR. |
|
Review please |
j0tunn
force-pushed
the
fix/android.retry.gatt.err.133
branch
from
03bc07d to
e730a88
Compare
|
PR #34697: Size comparison from 9946fc8 to e730a88 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Review please. |
|
@bzbarsky-apple Hi, can you help with review of this PR? |
andy31415
reviewed
Oct 24, 2024
andy31415
approved these changes
Oct 24, 2024
|
@j0tunn I can't review this; I know nothing about bluetooth on Android. I could rubber-stamp it without understanding it, but so can literally anyone else in the reviewers list, and most of them are carrying much lighter review loads than I am. |
j0tunn
force-pushed
the
fix/android.retry.gatt.err.133
branch
from
1b57f24 to
788d064
Compare
|
PR #34697: Size comparison from a3140e2 to 788d064 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
@andy31415 Thanks for review! |
No problem. Just didn't know how to push this PR, and you reviewed my other PR's, so I've decided to call you here. Sorry for bothering you. |
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ect-chip#34697) * feat: retry GATT_ERROR 133 on device.connectGatt fail * chore: add constant for error code 133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes device commissioning fails on
device.connectGattfail with low levelGATT_ERROR(133):GATT_ERROR 133is the generic error. It means "something went wrong, can't connect". In most cases solution is to close current gatt connection and try again.