Do not include Ble* platform specific files for Darwin if ble is not … #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
rwalker-apple and
saurabhst
vivien-apple
removed request for
andy31415,
saurabhst,
hawk248 and
chrisdecenzo
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
hawk248 and
saurabhst
andy31415
approved these changes
Oct 27, 2020
| @@ -197,13 +197,7 @@ if (chip_device_platform != "none" && chip_device_platform != "external") { | |||
| sources += [ | |||
| "Darwin/BLEManagerImpl.cpp", | |||
There was a problem hiding this comment.
should we also take out the BleManagerImpl.cpp (I believe it is currently one large #ifdef ?
rwalker-apple
approved these changes
Oct 27, 2020
saurabhst
approved these changes
Oct 27, 2020
BroderickCarlin
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…enabled
Problem
Some files that depends on BLE are included in the Darwin build even if Ble support is turned off. It creates linker issues.
Summary of Changes