-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec rename of HomeLocationStruct to LocationDescriptorStruct #34525
Merged
tehampson
merged 3 commits into
project-chip:master
from
tehampson:0725-home-location-struct-rename
Jul 26, 2024
Merged
Spec rename of HomeLocationStruct to LocationDescriptorStruct #34525
tehampson
merged 3 commits into
project-chip:master
from
tehampson:0725-home-location-struct-rename
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
July 26, 2024 03:00
pullapprove
bot
requested review from
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
July 26, 2024 03:00
PR #34525: Size comparison from 9421127 to f5d2a30 Full report (8 builds for cc32xx, mbed, qpg, stm32, tizen)
|
PR #34525: Size comparison from 9421127 to b46c8cf Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 26, 2024
src/app/zap-templates/zcl/data-model/chip/ecosystem-information-cluster.xml
Show resolved
Hide resolved
yufengwangca
approved these changes
Jul 26, 2024
tehampson
added
the
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
label
Jul 26, 2024
PR #34525: Size comparison from 9421127 to 83a9c93 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
review - approved
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10115 changed struct name from HomeLocationStruct to LocationDescriptorStruct. This reflects the spec text change
Backwards compatibility checker is skipped because ServiceArea is a provisional cluster and is marked as such now in this PR