Fix UNSUPPORTED_ENDPOINT of TC-BR-4's step 1h #34499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple and
kkasperczyk-no
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
|
PR #34499: Size comparison from 34462f1 to 8d79c14 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
When testing step 1h of TC-BR-4 with bridge-app on the latest TH, an UNSUPPORTED_ENDPOINT error occurs. This is because ComposedDevice and ComposedPowerSource are local variables in the ApplicationInit function, so they are not valid when the bridge-app runs. This change moves ComposedDevice and ComposedPowerSource to global scope. Co-authored-by: Charles Kim <[email protected]> Co-authored-by: Sanghee Kim <[email protected]> Co-authored-by: Hunsup Jung <[email protected]> Co-authored-by: sanghyukko <[email protected]> Co-authored-by: Jaehoon You <[email protected]> Co-authored-by: Kyu-Wook Lim <[email protected]> Signed-off-by: Youngho Yoon <[email protected]>
ComposedDevice has the same type and variable name, so an ambiguous
build error occurs as shown below. This change renames the variable to
gComposeDevice.
../../main.cpp: In function ‘void ApplicationInit()’:
../../main.cpp:924:5: error: reference to ‘ComposedDevice’ is ambiguous
924 | ComposedDevice.SetReachable(true);
| ^~~~~~~~~~~~~~
../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’
174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom");
| ^~~~~~~~~~~~~~
In file included from ../../main.cpp:46:
../../include/Device.h:158:7: note: ‘class ComposedDevice’
158 | class ComposedDevice : public Device
| ^~~~~~~~~~~~~~
../../main.cpp:954:24: error: reference to ‘ComposedDevice’ is ambiguous
954 | AddDeviceEndpoint(&ComposedDevice, &bridgedComposedDeviceEndpoint, Span<const EmberAfDeviceType>(gBridgedComposedDeviceTypes),
| ^~~~~~~~~~~~~~
../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’
174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom");
| ^~~~~~~~~~~~~~
In file included from ../../main.cpp:46:
../../include/Device.h:158:7: note: ‘class ComposedDevice’
158 | class ComposedDevice : public Device
| ^~~~~~~~~~~~~~
../../main.cpp:958:76: error: reference to ‘ComposedDevice’ is ambiguous
958 | Span<DataVersion>(gComposedTempSensor1DataVersions), ComposedDevice.GetEndpointId());
| ^~~~~~~~~~~~~~
../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’
174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom");
| ^~~~~~~~~~~~~~
In file included from ../../main.cpp:46:
../../include/Device.h:158:7: note: ‘class ComposedDevice’
158 | class ComposedDevice : public Device
| ^~~~~~~~~~~~~~
../../main.cpp:961:76: error: reference to ‘ComposedDevice’ is ambiguous
961 | Span<DataVersion>(gComposedTempSensor2DataVersions), ComposedDevice.GetEndpointId());
| ^~~~~~~~~~~~~~
../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’
174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom");
| ^~~~~~~~~~~~~~
In file included from ../../main.cpp:46:
../../include/Device.h:158:7: note: ‘class ComposedDevice’
158 | class ComposedDevice : public Device
| ^~~~~~~~~~~~~~
../../main.cpp:977:28: error: reference to ‘ComposedDevice’ is ambiguous
977 | endpointList.push_back(ComposedDevice.GetEndpointId());
| ^~~~~~~~~~~~~~
../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’
174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom");
| ^~~~~~~~~~~~~~
In file included from ../../main.cpp:46:
../../include/Device.h:158:7: note: ‘class ComposedDevice’
158 | class ComposedDevice : public Device
| ^~~~~~~~~~~~~~
../../main.cpp:981:39: error: reference to ‘ComposedDevice’ is ambiguous
981 | ComposedPowerSource.SetEndpointId(ComposedDevice.GetEndpointId());
| ^~~~~~~~~~~~~~
../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’
174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom");
| ^~~~~~~~~~~~~~
In file included from ../../main.cpp:46:
../../include/Device.h:158:7: note: ‘class ComposedDevice’
158 | class ComposedDevice : public Device
| ^~~~~~~~~~~~~~
At global scope:
cc1plus: error: unrecognized command line option ‘-Wno-unknown-warning-option’ [-Werror]
cc1plus: all warnings being treated as errors
ninja: build stopped: subcommand failed.
Signed-off-by: Youngho Yoon <[email protected]>
yhoyoon
force-pushed
the
feature/contribution-certificate
branch
from
8d79c14 to
c2b1090
Compare
|
PR #34499: Size comparison from 34462f1 to c2b1090 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34499: Size comparison from ba949bf to 3044cd0 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
chulspro
approved these changes
Jul 26, 2024
andy31415
approved these changes
Jul 26, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Fix UNSUPPORTED_ENDPOINT of TC-BR-4's step 1h When testing step 1h of TC-BR-4 with bridge-app on the latest TH, an UNSUPPORTED_ENDPOINT error occurs. This is because ComposedDevice and ComposedPowerSource are local variables in the ApplicationInit function, so they are not valid when the bridge-app runs. This change moves ComposedDevice and ComposedPowerSource to global scope. Co-authored-by: Charles Kim <[email protected]> Co-authored-by: Sanghee Kim <[email protected]> Co-authored-by: Hunsup Jung <[email protected]> Co-authored-by: sanghyukko <[email protected]> Co-authored-by: Jaehoon You <[email protected]> Co-authored-by: Kyu-Wook Lim <[email protected]> Signed-off-by: Youngho Yoon <[email protected]> * Fix ambiguous build error of bridge app ComposedDevice has the same type and variable name, so an ambiguous build error occurs as shown below. This change renames the variable to gComposeDevice. ../../main.cpp: In function ‘void ApplicationInit()’: ../../main.cpp:924:5: error: reference to ‘ComposedDevice’ is ambiguous 924 | ComposedDevice.SetReachable(true); | ^~~~~~~~~~~~~~ ../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’ 174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom"); | ^~~~~~~~~~~~~~ In file included from ../../main.cpp:46: ../../include/Device.h:158:7: note: ‘class ComposedDevice’ 158 | class ComposedDevice : public Device | ^~~~~~~~~~~~~~ ../../main.cpp:954:24: error: reference to ‘ComposedDevice’ is ambiguous 954 | AddDeviceEndpoint(&ComposedDevice, &bridgedComposedDeviceEndpoint, Span<const EmberAfDeviceType>(gBridgedComposedDeviceTypes), | ^~~~~~~~~~~~~~ ../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’ 174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom"); | ^~~~~~~~~~~~~~ In file included from ../../main.cpp:46: ../../include/Device.h:158:7: note: ‘class ComposedDevice’ 158 | class ComposedDevice : public Device | ^~~~~~~~~~~~~~ ../../main.cpp:958:76: error: reference to ‘ComposedDevice’ is ambiguous 958 | Span<DataVersion>(gComposedTempSensor1DataVersions), ComposedDevice.GetEndpointId()); | ^~~~~~~~~~~~~~ ../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’ 174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom"); | ^~~~~~~~~~~~~~ In file included from ../../main.cpp:46: ../../include/Device.h:158:7: note: ‘class ComposedDevice’ 158 | class ComposedDevice : public Device | ^~~~~~~~~~~~~~ ../../main.cpp:961:76: error: reference to ‘ComposedDevice’ is ambiguous 961 | Span<DataVersion>(gComposedTempSensor2DataVersions), ComposedDevice.GetEndpointId()); | ^~~~~~~~~~~~~~ ../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’ 174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom"); | ^~~~~~~~~~~~~~ In file included from ../../main.cpp:46: ../../include/Device.h:158:7: note: ‘class ComposedDevice’ 158 | class ComposedDevice : public Device | ^~~~~~~~~~~~~~ ../../main.cpp:977:28: error: reference to ‘ComposedDevice’ is ambiguous 977 | endpointList.push_back(ComposedDevice.GetEndpointId()); | ^~~~~~~~~~~~~~ ../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’ 174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom"); | ^~~~~~~~~~~~~~ In file included from ../../main.cpp:46: ../../include/Device.h:158:7: note: ‘class ComposedDevice’ 158 | class ComposedDevice : public Device | ^~~~~~~~~~~~~~ ../../main.cpp:981:39: error: reference to ‘ComposedDevice’ is ambiguous 981 | ComposedPowerSource.SetEndpointId(ComposedDevice.GetEndpointId()); | ^~~~~~~~~~~~~~ ../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’ 174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom"); | ^~~~~~~~~~~~~~ In file included from ../../main.cpp:46: ../../include/Device.h:158:7: note: ‘class ComposedDevice’ 158 | class ComposedDevice : public Device | ^~~~~~~~~~~~~~ At global scope: cc1plus: error: unrecognized command line option ‘-Wno-unknown-warning-option’ [-Werror] cc1plus: all warnings being treated as errors ninja: build stopped: subcommand failed. Signed-off-by: Youngho Yoon <[email protected]> --------- Signed-off-by: Youngho Yoon <[email protected]> Co-authored-by: Charles Kim <[email protected]> Co-authored-by: Sanghee Kim <[email protected]> Co-authored-by: Hunsup Jung <[email protected]> Co-authored-by: sanghyukko <[email protected]> Co-authored-by: Jaehoon You <[email protected]> Co-authored-by: Kyu-Wook Lim <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Fix UNSUPPORTED_ENDPOINT of TC-BR-4's step 1h When testing step 1h of TC-BR-4 with bridge-app on the latest TH, an UNSUPPORTED_ENDPOINT error occurs. This is because ComposedDevice and ComposedPowerSource are local variables in the ApplicationInit function, so they are not valid when the bridge-app runs. This change moves ComposedDevice and ComposedPowerSource to global scope. Co-authored-by: Charles Kim <[email protected]> Co-authored-by: Sanghee Kim <[email protected]> Co-authored-by: Hunsup Jung <[email protected]> Co-authored-by: sanghyukko <[email protected]> Co-authored-by: Jaehoon You <[email protected]> Co-authored-by: Kyu-Wook Lim <[email protected]> Signed-off-by: Youngho Yoon <[email protected]> * Fix ambiguous build error of bridge app ComposedDevice has the same type and variable name, so an ambiguous build error occurs as shown below. This change renames the variable to gComposeDevice. ../../main.cpp: In function ‘void ApplicationInit()’: ../../main.cpp:924:5: error: reference to ‘ComposedDevice’ is ambiguous 924 | ComposedDevice.SetReachable(true); | ^~~~~~~~~~~~~~ ../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’ 174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom"); | ^~~~~~~~~~~~~~ In file included from ../../main.cpp:46: ../../include/Device.h:158:7: note: ‘class ComposedDevice’ 158 | class ComposedDevice : public Device | ^~~~~~~~~~~~~~ ../../main.cpp:954:24: error: reference to ‘ComposedDevice’ is ambiguous 954 | AddDeviceEndpoint(&ComposedDevice, &bridgedComposedDeviceEndpoint, Span<const EmberAfDeviceType>(gBridgedComposedDeviceTypes), | ^~~~~~~~~~~~~~ ../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’ 174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom"); | ^~~~~~~~~~~~~~ In file included from ../../main.cpp:46: ../../include/Device.h:158:7: note: ‘class ComposedDevice’ 158 | class ComposedDevice : public Device | ^~~~~~~~~~~~~~ ../../main.cpp:958:76: error: reference to ‘ComposedDevice’ is ambiguous 958 | Span<DataVersion>(gComposedTempSensor1DataVersions), ComposedDevice.GetEndpointId()); | ^~~~~~~~~~~~~~ ../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’ 174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom"); | ^~~~~~~~~~~~~~ In file included from ../../main.cpp:46: ../../include/Device.h:158:7: note: ‘class ComposedDevice’ 158 | class ComposedDevice : public Device | ^~~~~~~~~~~~~~ ../../main.cpp:961:76: error: reference to ‘ComposedDevice’ is ambiguous 961 | Span<DataVersion>(gComposedTempSensor2DataVersions), ComposedDevice.GetEndpointId()); | ^~~~~~~~~~~~~~ ../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’ 174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom"); | ^~~~~~~~~~~~~~ In file included from ../../main.cpp:46: ../../include/Device.h:158:7: note: ‘class ComposedDevice’ 158 | class ComposedDevice : public Device | ^~~~~~~~~~~~~~ ../../main.cpp:977:28: error: reference to ‘ComposedDevice’ is ambiguous 977 | endpointList.push_back(ComposedDevice.GetEndpointId()); | ^~~~~~~~~~~~~~ ../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’ 174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom"); | ^~~~~~~~~~~~~~ In file included from ../../main.cpp:46: ../../include/Device.h:158:7: note: ‘class ComposedDevice’ 158 | class ComposedDevice : public Device | ^~~~~~~~~~~~~~ ../../main.cpp:981:39: error: reference to ‘ComposedDevice’ is ambiguous 981 | ComposedPowerSource.SetEndpointId(ComposedDevice.GetEndpointId()); | ^~~~~~~~~~~~~~ ../../main.cpp:174:16: note: candidates are: ‘ComposedDevice {anonymous}::ComposedDevice’ 174 | ComposedDevice ComposedDevice("Composed Device", "Bedroom"); | ^~~~~~~~~~~~~~ In file included from ../../main.cpp:46: ../../include/Device.h:158:7: note: ‘class ComposedDevice’ 158 | class ComposedDevice : public Device | ^~~~~~~~~~~~~~ At global scope: cc1plus: error: unrecognized command line option ‘-Wno-unknown-warning-option’ [-Werror] cc1plus: all warnings being treated as errors ninja: build stopped: subcommand failed. Signed-off-by: Youngho Yoon <[email protected]> --------- Signed-off-by: Youngho Yoon <[email protected]> Co-authored-by: Charles Kim <[email protected]> Co-authored-by: Sanghee Kim <[email protected]> Co-authored-by: Hunsup Jung <[email protected]> Co-authored-by: sanghyukko <[email protected]> Co-authored-by: Jaehoon You <[email protected]> Co-authored-by: Kyu-Wook Lim <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing step 1h of TC-BR-4 with bridge-app on the latest TH, an
UNSUPPORTED_ENDPOINTerror occurs. This is because ComposedDevice and ComposedPowerSource are local variables in theApplicationInitfunction, so they are not valid when the bridge-app runs. This change moves ComposedDevice and ComposedPowerSource to global scope.Error logs:
Fixed bridge-app's logs: