Make AttributeAccessInterface and CommandHandlerInterface registries consistent as objects with singletons #34462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic and
dhrishi
|
PR #34462: Size comparison from 3b97495 to 3740379 Full report (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #34462: Size comparison from 3b97495 to b9a7ad0 Increases above 0.2%:
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34462: Size comparison from c88d5cf to bfee9c5 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34462: Size comparison from 1b83c3a to 19a9634 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34462: Size comparison from 2a60735 to e18ca61 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
If we're changing these APIs anyway, we should consider merging AttributeAccessInterface and CommandHandlerInterface. In most cases cluster servers implement both interfaces, so this would reduce the amount of code required to register a cluster server, as well as memory used by cluster server instances and the registries themselves.
I plan to make this change, however for backwards compatibility I am placing after the DM::Provider interface split and usage. |
|
PR #34462: Size comparison from e58e16e to 1756f4d Full report (29 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #34462: Size comparison from e58e16e to cd95582 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
Aug 7, 2024
cecille
approved these changes
Aug 7, 2024
|
PR #34462: Size comparison from e0a765b to 13b0112 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Aug 12, 2024
…consistent as objects with singletons (project-chip#34462) * Switch CHI registry to an object * Switch CHI registry to an object * Prepare the AAI registry to use an object * Replace unregister * Replace the register * Update the getter * Restyle * Fix unregister * Fix typo * Fix namespacing for instance * Do not make IME auto-clear command handlers * Make spellcheck happy * Remove chip::app prefix throughout * Fix compile error * One more compile fix * One more compile fix * make tv-app compile * Update examples/all-clusters-app/all-clusters-common/src/bridged-actions-stub.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/tv-app/android/java/AppImpl.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update register/unregister names * Fix endpoint id usage that was awkward in aai * Restyle * Code simplification and some namespace removal * Fix comment * re-order of methods * One more move to preserve previous order * Restyle * Add back the odd clear * Add missing invalidation of AAI cache * Fix compile * one more compile fix * more compile fixes --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes both AAI and CHI consistent: objects with an
Instancemethod and UpperCamelCase method names.This is a followup on #34414