-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ecosystem Information Cluster Server implementation #34459
Merged
tehampson
merged 13 commits into
project-chip:master
from
tehampson:0716-ecosystem-cluster-sdk-server-impl-upload
Jul 26, 2024
Merged
Add Ecosystem Information Cluster Server implementation #34459
tehampson
merged 13 commits into
project-chip:master
from
tehampson:0716-ecosystem-cluster-sdk-server-impl-upload
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple and
kkasperczyk-no
July 23, 2024 14:56
andy31415
reviewed
Jul 23, 2024
src/app/clusters/ecosystem-information-server/ecosystem-information-server.cpp
Show resolved
Hide resolved
andy31415
reviewed
Jul 23, 2024
src/app/clusters/ecosystem-information-server/ecosystem-information-server.cpp
Show resolved
Hide resolved
andy31415
reviewed
Jul 23, 2024
src/app/clusters/ecosystem-information-server/ecosystem-information-server.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Jul 23, 2024
src/app/clusters/ecosystem-information-server/ecosystem-information-server.cpp
Show resolved
Hide resolved
andy31415
reviewed
Jul 23, 2024
src/app/clusters/ecosystem-information-server/ecosystem-information-server.cpp
Outdated
Show resolved
Hide resolved
PR #34459: Size comparison from 63959ca to d97eb61 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34459: Size comparison from 63959ca to 68d2dff Increases above 0.2%:
Full report (3 builds for nrfconnect)
|
andy31415
approved these changes
Jul 25, 2024
yufengwangca
approved these changes
Jul 26, 2024
bzbarsky-apple
approved these changes
Jul 26, 2024
src/app/clusters/ecosystem-information-server/ecosystem-information-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/ecosystem-information-server/ecosystem-information-server.cpp
Outdated
Show resolved
Hide resolved
PR #34459: Size comparison from bdbf6ac to 696d42d Full report (4 builds for cc32xx, mbed, stm32)
|
PR #34459: Size comparison from bdbf6ac to f345788 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Ecosystem Information Cluster Server implementation to
src/app/clusters/
for provisional fabric syncThis registers AttributeAccessInterface so that we can override the read attributes. This instance was developed in a way so that ownership of the underlying types are embedded into the Device and Location structs themselves and that we would only create instance of those structs if the data is valid.
To be completed in follow up PRs:
Testing:
With local changes to
examples/fabric-bridge-app/
confirmed was able to read attributes from EcosystemInformationCluster