Mark session for eviction on TCP Client side when disconnecting with peer. #34451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34451: Size comparison from d666567 to c3df536 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Jul 23, 2024
bzbarsky-apple
approved these changes
Jul 23, 2024
pidarped
force-pushed
the
FixTCPDisconnect
branch
from
c3df536 to
1168813
Compare
|
PR #34451: Size comparison from 985a9b0 to 1168813 Full report (48 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nxp, psoc6, qpg, stm32, tizen)
|
pidarped
force-pushed
the
FixTCPDisconnect
branch
from
1168813 to
beea727
Compare
pidarped
changed the title
…peer. The TCP server on receiving a TCPDisconnect from the client marks the corresponding secure session for eviction. The TCP client should also mark its session for eviction when proactively closing the connection with peer.
pidarped
force-pushed
the
FixTCPDisconnect
branch
from
beea727 to
67ff786
Compare
bzbarsky-apple
approved these changes
Jul 23, 2024
|
PR #34451: Size comparison from c0d76b3 to 67ff786 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…peer. (project-chip#34451) The TCP server on receiving a TCPDisconnect from the client marks the corresponding secure session for eviction. The TCP client should also mark its session for eviction when proactively closing the connection with peer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TCP server on receiving a TCPDisconnect from the client marks the corresponding secure session for eviction.
The TCP client should also mark its session for eviction when proactively closing the connection with peer.