[Silabs] Cleanup of logs and checks for WiFi products #34430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brosahay
force-pushed
the
refactor/silabs-log-cleanup
branch
from
9cea442 to
90fd541
Compare
|
PR #34430: Size comparison from 47cec4e to 3939a53 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34430: Size comparison from 47cec4e to e90666b Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34430: Size comparison from 47cec4e to 0204395 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34430: Size comparison from 47cec4e to c177995 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34430: Size comparison from 13fe13a to 9ddb579 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
brosahay
force-pushed
the
refactor/silabs-log-cleanup
branch
from
9ddb579 to
3dd6aa3
Compare
|
PR #34430: Size comparison from 681f951 to bf6ea4c Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34430: Size comparison from 3b90fed to d96f352 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
rosahay-silabs
force-pushed
the
refactor/silabs-log-cleanup
branch
2 times, most recently
from
9de2fd7 to
3f8c32c
Compare
|
PR #34430: Size comparison from daa2a57 to 3f8c32c Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
rosahay-silabs
force-pushed
the
refactor/silabs-log-cleanup
branch
from
4e44cac to
ce8d2e6
Compare
|
PR #34430: Size comparison from 010d982 to ce8d2e6 Full report (74 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
rosahay-silabs
force-pushed
the
refactor/silabs-log-cleanup
branch
from
ce8d2e6 to
d5916d7
Compare
|
PR #34430: Size comparison from 0851382 to d5916d7 Full report (74 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
brosahay
force-pushed
the
refactor/silabs-log-cleanup
branch
from
d5916d7 to
cdb8862
Compare
|
PR #34430: Size comparison from 05b60aa to cdb8862 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq and
axelnxp
jmartinez-silabs
approved these changes
Aug 29, 2024
rosahay-silabs
force-pushed
the
refactor/silabs-log-cleanup
branch
3 times, most recently
from
c30a091 to
523c9cf
Compare
rosahay-silabs
force-pushed
the
refactor/silabs-log-cleanup
branch
from
523c9cf to
ff4047e
Compare
|
PR #34430: Size comparison from 30cff8e to 64cbfa6 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34430: Size comparison from 30cff8e to 057ae24 Increases above 0.2%:
Full report (41 builds for bl602, bl702, bl702l, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
rosahay-silabs
force-pushed
the
refactor/silabs-log-cleanup
branch
from
057ae24 to
0cb1a7d
Compare
|
PR #34430: Size comparison from 2cf028b to 0cb1a7d Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Sep 6, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…4430) * Clean up of logs and added checks * Apply suggestions from code review Co-authored-by: Junior Martinez <[email protected]> * Added changes from code review * Replace with chip::platform memory functions * Reduce logs * chore: Fix logging statements and improve error handling in BaseApplication.cpp * Sanitize provisioning WiFi network credentials * Sanitize SSID and SSID length * use CodeUtils min functions * refactor: add void parameter to functions * refactor: fix logging format in wfx_rsi_join_fail_cb and wfx_rsi_init functions * Simplify SSID processing and improve memory handling --------- Co-authored-by: brosahay <[email protected]> Co-authored-by: Junior Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains the following:
SILABS_LOGwithChipLog*MACROs.